Re: commit 7e92b4fc34 - x86, serial: convert legacy COM ports to platform devices - broke my serial console

["Yinghai Lu" <yhlu.kernel@gmail.com>]

On 7/25/07, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> On Tuesday 24 July 2007 10:27:26 pm Yinghai Lu wrote:
> > On 7/24/07, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> > > On Tuesday 24 July 2007 02:33:05 pm Yinghai Lu wrote:
> > > > I have a system that has the same problem, and it turns out that FW
> > > > missed PNP0501 is DSDT for uart. and add that it into DSDT works well.
> > >
> > > Is this FW that has been shipped?  Can you give any more details,
> > > like DMI info and a copy of the DSDT?  We can't expect users to
> > > upgrade their firmware or use a custom DSDT.
> >
> > The system is not shipped yet.
> > Normally PNP0501 is coming with superio section in DSDT. So i think
> > late BIOS if have acpi there, that should be there already.
> > Problem is that some new design may get rid of superio, but SB could
> > have extra uart for serial port. at that case BIOS may not have that
> > PNP0501...
>
> If the system has a non-PCI UART that is usable by the OS, it
> should be described by ACPI.  This is true regardless of whether
> the UART is attached via superio or elsewhere.
>
> So in this case, my patch just helped expose a defect in the
> firmware, and it sounds like the firmware was fixed before
> ever being shipped.

Yeah.

>
> > or we can make legacy_serial.force=1 is default at this point.
>
> At which point?  We already do the legacy probe if there are no
> PNP devices.  Do you mean we should also do the legacy probe if
> there are PNP devices, but no serial devices were found?  That
> might be reasonable to do, but wouldn't have prevented the problem
> on Sebastien's machine, because his machine *does* have PNP UARTs.

but still could have problem. if the system does not have any uart,
and So we can not find that in DSDT...and we add legacy again...that
is not right.

YH