From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus <torvalds@linux-foundation.org>
Subject: Re: [PATCH] APM support depends on CONFIG_PM_SLEEP
Date: Mon, 30 Jul 2007 17:01:45 +0200 [thread overview]
Message-ID: <200707301701.45880.rjw@sisk.pl> (raw)
In-Reply-To: <20070730201237.67f1a64a.sfr@canb.auug.org.au>
On Monday, 30 July 2007 12:12, Stephen Rothwell wrote:
> Commit 296699de6bdc717189a331ab6bbe90e05c94db06 broke building APM
> support if CONFIG_PM_SLEEP is not set.
Sorry for the breakage, my fault.
> Reported by Toralf Förster <toralf.foerster@gmx.de>
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> arch/i386/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
>
> diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig
> index abb582b..7eefa7d 100644
> --- a/arch/i386/Kconfig
> +++ b/arch/i386/Kconfig
> @@ -938,7 +938,7 @@ source "drivers/acpi/Kconfig"
>
> menuconfig APM
> tristate "APM (Advanced Power Management) BIOS support"
> - depends on PM && !X86_VISWS
> + depends on PM && !X86_VISWS && PM_SLEEP
PM_SLEEP depends on PM, so I'd do
+ depends on PM_SLEEP && !X86_VISWS
> ---help---
> APM is a BIOS specification for saving power using several different
> techniques. This is mostly useful for battery powered laptops with
Greetings,
Rafael
--
"Premature optimization is the root of all evil." - Donald Knuth
parent reply other threads:[~2007-07-30 14:53 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20070730201237.67f1a64a.sfr@canb.auug.org.au>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707301701.45880.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®