* Re: [PATCH] APM support depends on CONFIG_PM_SLEEP
[not found] <20070730201237.67f1a64a.sfr@canb.auug.org.au>
@ 2007-07-30 15:01 ` Rafael J. Wysocki
0 siblings, 0 replies; only message in thread
From: Rafael J. Wysocki @ 2007-07-30 15:01 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: LKML, Andrew Morton, Linus
On Monday, 30 July 2007 12:12, Stephen Rothwell wrote:
> Commit 296699de6bdc717189a331ab6bbe90e05c94db06 broke building APM
> support if CONFIG_PM_SLEEP is not set.
Sorry for the breakage, my fault.
> Reported by Toralf Förster <toralf.foerster@gmx.de>
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> arch/i386/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
>
> diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig
> index abb582b..7eefa7d 100644
> --- a/arch/i386/Kconfig
> +++ b/arch/i386/Kconfig
> @@ -938,7 +938,7 @@ source "drivers/acpi/Kconfig"
>
> menuconfig APM
> tristate "APM (Advanced Power Management) BIOS support"
> - depends on PM && !X86_VISWS
> + depends on PM && !X86_VISWS && PM_SLEEP
PM_SLEEP depends on PM, so I'd do
+ depends on PM_SLEEP && !X86_VISWS
> ---help---
> APM is a BIOS specification for saving power using several different
> techniques. This is mostly useful for battery powered laptops with
Greetings,
Rafael
--
"Premature optimization is the root of all evil." - Donald Knuth
^ permalink raw reply [flat|nested] only message in thread