mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Vasquez <andrew.vasquez@qlogic.com>
To: James Bottomley <james.bottomley@steeleye.com>
Cc: Ulrich Windl <ulrich.windl@rz.uni-regensburg.de>,
	Andrew Patterson <andrew.patterson@hp.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] qla2xxx: allocate enough space for the full PCI descriptor.
Date: Wed, 1 Aug 2007 15:13:40 -0700	[thread overview]
Message-ID: <20070801221340.GA4370@plap.qlogic.org> (raw)
In-Reply-To: <20070727062343.GC15408@plap.qlogic.org>

Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
---

	On Thu, 26 Jul 2007, Andrew Vasquez wrote:

	> On Thu, 26 Jul 2007, Andrew Patterson wrote:
	> 
	> > On Thu, 2007-07-26 at 15:36 +0200, Ulrich Windl wrote:
	> > > Hi,
	> > > 
	> > > <6>QLogic Fibre Channel HBA Driver
	> > > <6>GSI 49 (level, low) -> CPU 3 (0x0300) vector 51
	> > > <6>ACPI: PCI Interrupt 0000:0f:01.0[A] -> GSI 49 (level, low) -> IRQ 51
	> > > <6>qla2xxx 0000:0f:01.0: Found an ISP2422, irq 51, iobase 0xc0000000b0040000
	> > > [...]
	> > > <6>qla2xxx 0000:0f:01.0: LOOP UP detected (4 Gbps).
	> > > <6>qla2xxx 0000:0f:01.0: Topology - (F_Port), Host Loop address 0x0
	> > > <6>scsi0 : qla2xxx
	> > > <6>qla2xxx 0000:0f:01.0:
	> > > <4> QLogic Fibre Channel HBA Driver: 8.01.07-k3
	> > > <4>  QLogic HP AB378-60001 -
	> > > <4>  ISP2422: PCI-X Mode 2 (133 MH4.00.26 [IP]  @ 0000:0f:01.0 hdma+, host#=0, 
	> > > fw=4.00.26 [IP]
	> 
	> The 33/66/100/133 values refer to the bus-clock speed at which the
	> card is operating.  As is seen here (although a bit truncated --
	> separate issue, I'll try to see if I can reproduce this on one of my
	> HPQ rigs),

	Ok, so what's happening here is the buffer passed in (pci_info)
	does not have bytes allocated (off by 3).

	James, please apply...

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 93c0c7e..acca898 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -1564,7 +1564,7 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
 	struct Scsi_Host *host;
 	scsi_qla_host_t *ha;
 	unsigned long	flags = 0;
-	char pci_info[20];
+	char pci_info[30];
 	char fw_str[30];
 	struct scsi_host_template *sht;
 

      parent reply	other threads:[~2007-08-01 22:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-26 13:36 Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA) Ulrich Windl
2007-07-26 22:03 ` Andrew Patterson
2007-07-27  6:23   ` Andrew Vasquez
2007-07-27 15:46     ` Andrew Patterson
2007-07-27 16:11       ` Andrew Vasquez
2007-07-31 16:50         ` Andrew Vasquez
2007-08-01  6:13           ` Ulrich Windl
2007-07-30  6:40       ` Ulrich Windl
2007-08-01 22:13     ` Andrew Vasquez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070801221340.GA4370@plap.qlogic.org \
    --to=andrew.vasquez@qlogic.com \
    --cc=andrew.patterson@hp.com \
    --cc=james.bottomley@steeleye.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ulrich.windl@rz.uni-regensburg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®