Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

[Ulrich Windl]

Hi,

I have a question: The Qlogic ISP2422 chip is said to handle PCI-X 266MHz. So does 
the HP Itanium2 server rx6600. Basically that was the reason to select that 
server. The FC-HBA is in a 266 MHz capable slot. However when booting SLES10 SP1 
for IA64, the logs say:

<6>QLogic Fibre Channel HBA Driver
<6>GSI 49 (level, low) -> CPU 3 (0x0300) vector 51
<6>ACPI: PCI Interrupt 0000:0f:01.0[A] -> GSI 49 (level, low) -> IRQ 51
<6>qla2xxx 0000:0f:01.0: Found an ISP2422, irq 51, iobase 0xc0000000b0040000
[...]
<6>qla2xxx 0000:0f:01.0: LOOP UP detected (4 Gbps).
<6>qla2xxx 0000:0f:01.0: Topology - (F_Port), Host Loop address 0x0
<6>scsi0 : qla2xxx
<6>qla2xxx 0000:0f:01.0:
<4> QLogic Fibre Channel HBA Driver: 8.01.07-k3
<4>  QLogic HP AB378-60001 -
<4>  ISP2422: PCI-X Mode 2 (133 MH4.00.26 [IP]  @ 0000:0f:01.0 hdma+, host#=0, 
fw=4.00.26 [IP]
<5>  Vendor: HP        Model: HSV200            Rev: 6100
<5>  Type:   RAID                               ANSI SCSI revision: 02
<5> 0:0:0:0: Attached scsi generic sg0 type 12

Now does Linux support the speed of 266 MHz, and is it just displayed incorrectly, 
or doesn't Linux support the speed of 266MHz yet?

"lspci -v" says:
0f:01.0 Fibre Channel: QLogic Corp. ISP2422-based 4Gb Fibre Channel to PCI-X HBA 
(rev 02)
        Subsystem: Hewlett-Packard Company Unknown device 12d6
        Flags: bus master, 66MHz, medium devsel, latency 128, IRQ 51
        I/O ports at 6000 [size=256]
        Memory at b0040000 (64-bit, non-prefetchable) [size=4K]
        Expansion ROM at b0000000 [disabled] [size=256K]
        Capabilities: [44] Power Management version 2
        Capabilities: [4c] PCI-X non-bridge device
        Capabilities: [64] Message Signalled Interrupts: Mask- 64bit+ Queue=0/3 
Enable-
        Capabilities: [74] Vital Product Data

Please CC: any replies to my address as I'm not subscribed to the kernel list.

Regards,
Ulrich Windl

Re: Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

[Andrew Patterson]

On Thu, 2007-07-26 at 15:36 +0200, Ulrich Windl wrote:
> Hi,
> 
> I have a question: The Qlogic ISP2422 chip is said to handle PCI-X 266MHz. So does 
> the HP Itanium2 server rx6600. Basically that was the reason to select that 
> server. The FC-HBA is in a 266 MHz capable slot. However when booting SLES10 SP1 
> for IA64, the logs say:
> 
> <6>QLogic Fibre Channel HBA Driver
> <6>GSI 49 (level, low) -> CPU 3 (0x0300) vector 51
> <6>ACPI: PCI Interrupt 0000:0f:01.0[A] -> GSI 49 (level, low) -> IRQ 51
> <6>qla2xxx 0000:0f:01.0: Found an ISP2422, irq 51, iobase 0xc0000000b0040000
> [...]
> <6>qla2xxx 0000:0f:01.0: LOOP UP detected (4 Gbps).
> <6>qla2xxx 0000:0f:01.0: Topology - (F_Port), Host Loop address 0x0
> <6>scsi0 : qla2xxx
> <6>qla2xxx 0000:0f:01.0:
> <4> QLogic Fibre Channel HBA Driver: 8.01.07-k3
> <4>  QLogic HP AB378-60001 -
> <4>  ISP2422: PCI-X Mode 2 (133 MH4.00.26 [IP]  @ 0000:0f:01.0 hdma+, host#=0, 
> fw=4.00.26 [IP]
> <5>  Vendor: HP        Model: HSV200            Rev: 6100
> <5>  Type:   RAID                               ANSI SCSI revision: 02
> <5> 0:0:0:0: Attached scsi generic sg0 type 12
> 
> Now does Linux support the speed of 266 MHz, and is it just displayed incorrectly, 
> or doesn't Linux support the speed of 266MHz yet?

This is a bug in the driver.  The lookup table only goes to 133 MHz.

static char *pci_bus_modes[] = {
                "33", "66", "100", "133",

The same problem exists in the scsi_misc tree.

> "lspci -v" says:
> 0f:01.0 Fibre Channel: QLogic Corp. ISP2422-based 4Gb Fibre Channel to PCI-X HBA 
> (rev 02)
>         Subsystem: Hewlett-Packard Company Unknown device 12d6
>         Flags: bus master, 66MHz, medium devsel, latency 128, IRQ 51
>         I/O ports at 6000 [size=256]
>         Memory at b0040000 (64-bit, non-prefetchable) [size=4K]
>         Expansion ROM at b0000000 [disabled] [size=256K]
>         Capabilities: [44] Power Management version 2
>         Capabilities: [4c] PCI-X non-bridge device
>         Capabilities: [64] Message Signalled Interrupts: Mask- 64bit+ Queue=0/3 
> Enable-
>         Capabilities: [74] Vital Product Data
> 

lspci only tells you capabilities, not the speed that the card is
running at.  I think you have to query the PCI bridge chipset to get
this information.  I have run a proprietary tool on this configuration
that does this and confirmed that the card is indeed running at 266 MHz.

> Please CC: any replies to my address as I'm not subscribed to the kernel list.
> 
> Regards,
> Ulrich Windl

Andrew

-- 
Andrew Patterson
Hewlett-Packard Company

Re: Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

[Andrew Vasquez]

On Thu, 26 Jul 2007, Andrew Patterson wrote:

> On Thu, 2007-07-26 at 15:36 +0200, Ulrich Windl wrote:
> > Hi,
> > 
> > I have a question: The Qlogic ISP2422 chip is said to handle PCI-X 266MHz. So does 
> > the HP Itanium2 server rx6600. Basically that was the reason to select that 
> > server. The FC-HBA is in a 266 MHz capable slot. However when booting SLES10 SP1 
> > for IA64, the logs say:

There's a mixup here in terminology...  The QLA2460 card which you
have does in fact support 'PCI-X 266'...

> > <6>QLogic Fibre Channel HBA Driver
> > <6>GSI 49 (level, low) -> CPU 3 (0x0300) vector 51
> > <6>ACPI: PCI Interrupt 0000:0f:01.0[A] -> GSI 49 (level, low) -> IRQ 51
> > <6>qla2xxx 0000:0f:01.0: Found an ISP2422, irq 51, iobase 0xc0000000b0040000
> > [...]
> > <6>qla2xxx 0000:0f:01.0: LOOP UP detected (4 Gbps).
> > <6>qla2xxx 0000:0f:01.0: Topology - (F_Port), Host Loop address 0x0
> > <6>scsi0 : qla2xxx
> > <6>qla2xxx 0000:0f:01.0:
> > <4> QLogic Fibre Channel HBA Driver: 8.01.07-k3
> > <4>  QLogic HP AB378-60001 -
> > <4>  ISP2422: PCI-X Mode 2 (133 MH4.00.26 [IP]  @ 0000:0f:01.0 hdma+, host#=0, 
> > fw=4.00.26 [IP]

The 33/66/100/133 values refer to the bus-clock speed at which the
card is operating.  As is seen here (although a bit truncated --
separate issue, I'll try to see if I can reproduce this on one of my
HPQ rigs), the card is inserted into a PCI-X Mode-2 capable 133MHz
(bus clock) slot.  When operating under this mode, each data-phase
between two devices is divided into 2 sub-phases, effectively doubling
the transfer-data-rate to 266Mhz.

> > <5>  Vendor: HP        Model: HSV200            Rev: 6100
> > <5>  Type:   RAID                               ANSI SCSI revision: 02
> > <5> 0:0:0:0: Attached scsi generic sg0 type 12
> > 
> > Now does Linux support the speed of 266 MHz, and is it just displayed incorrectly, 
> > or doesn't Linux support the speed of 266MHz yet?
> 
> This is a bug in the driver.  The lookup table only goes to 133 MHz.
> 
> static char *pci_bus_modes[] = {
>                 "33", "66", "100", "133",
> 
> The same problem exists in the scsi_misc tree.

Regards,
Andrew Vasquez

Re: Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

[Andrew Patterson]

On Thu, 2007-07-26 at 23:23 -0700, Andrew Vasquez wrote:
> On Thu, 26 Jul 2007, Andrew Patterson wrote:
> 
> > On Thu, 2007-07-26 at 15:36 +0200, Ulrich Windl wrote:
> > > Hi,
> > > 
> > > I have a question: The Qlogic ISP2422 chip is said to handle PCI-X 266MHz. So does 
> > > the HP Itanium2 server rx6600. Basically that was the reason to select that 
> > > server. The FC-HBA is in a 266 MHz capable slot. However when booting SLES10 SP1 
> > > for IA64, the logs say:
> 
> There's a mixup here in terminology...  The QLA2460 card which you
> have does in fact support 'PCI-X 266'...
> 
> > > <6>QLogic Fibre Channel HBA Driver
> > > <6>GSI 49 (level, low) -> CPU 3 (0x0300) vector 51
> > > <6>ACPI: PCI Interrupt 0000:0f:01.0[A] -> GSI 49 (level, low) -> IRQ 51
> > > <6>qla2xxx 0000:0f:01.0: Found an ISP2422, irq 51, iobase 0xc0000000b0040000
> > > [...]
> > > <6>qla2xxx 0000:0f:01.0: LOOP UP detected (4 Gbps).
> > > <6>qla2xxx 0000:0f:01.0: Topology - (F_Port), Host Loop address 0x0
> > > <6>scsi0 : qla2xxx
> > > <6>qla2xxx 0000:0f:01.0:
> > > <4> QLogic Fibre Channel HBA Driver: 8.01.07-k3
> > > <4>  QLogic HP AB378-60001 -
> > > <4>  ISP2422: PCI-X Mode 2 (133 MH4.00.26 [IP]  @ 0000:0f:01.0 hdma+, host#=0, 
> > > fw=4.00.26 [IP]
> 
> The 33/66/100/133 values refer to the bus-clock speed at which the
> card is operating.  As is seen here (although a bit truncated --
> separate issue, I'll try to see if I can reproduce this on one of my
> HPQ rigs), the card is inserted into a PCI-X Mode-2 capable 133MHz
> (bus clock) slot.  When operating under this mode, each data-phase
> between two devices is divided into 2 sub-phases, effectively doubling
> the transfer-data-rate to 266Mhz.

I guess the proper terminology would be 266 MT/s (Mega
Transfers/second). Looking through the PSI_SIG PCI-X 2.0 marketing
blurbs, they use MHz a lot when referring to MT/S. So I would still
consider this to be a minor bug.  The user wants to know the transfer
rate, not the actual frequency of the bus.  Maybe just print out the
mode used instead, e.g., "PCI-X 266"?

> 
> > > <5>  Vendor: HP        Model: HSV200            Rev: 6100
> > > <5>  Type:   RAID                               ANSI SCSI revision: 02
> > > <5> 0:0:0:0: Attached scsi generic sg0 type 12
> > > 
> > > Now does Linux support the speed of 266 MHz, and is it just displayed incorrectly, 
> > > or doesn't Linux support the speed of 266MHz yet?
> > 
> > This is a bug in the driver.  The lookup table only goes to 133 MHz.
> > 
> > static char *pci_bus_modes[] = {
> >                 "33", "66", "100", "133",
> > 
> > The same problem exists in the scsi_misc tree.
> 
> Regards,
> Andrew Vasquez

-- 
Andrew Patterson
Hewlett-Packard Company

Re: Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

[Andrew Vasquez]

On Fri, 27 Jul 2007, Andrew Patterson wrote:

> On Thu, 2007-07-26 at 23:23 -0700, Andrew Vasquez wrote:
>
> > The 33/66/100/133 values refer to the bus-clock speed at which the
> > card is operating.  As is seen here (although a bit truncated --
> > separate issue, I'll try to see if I can reproduce this on one of my
> > HPQ rigs), the card is inserted into a PCI-X Mode-2 capable 133MHz
> > (bus clock) slot.  When operating under this mode, each data-phase
> > between two devices is divided into 2 sub-phases, effectively doubling
> > the transfer-data-rate to 266Mhz.
> 
> I guess the proper terminology would be 266 MT/s (Mega
> Transfers/second). Looking through the PSI_SIG PCI-X 2.0 marketing
> blurbs, they use MHz a lot when referring to MT/S. So I would still
> consider this to be a minor bug.  The user wants to know the transfer
> rate, not the actual frequency of the bus.  Maybe just print out the
> mode used instead, e.g., "PCI-X 266"?

That sounds reasonable.  I'll spin some patches today after I verify
all the bus-bits with the PUI group.

Thanks,
Andrew Vasquez

Re: Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

[Andrew Vasquez]

> On Fri, 27 Jul 2007, Andrew Patterson wrote:
> 
> > On Thu, 2007-07-26 at 23:23 -0700, Andrew Vasquez wrote:
> >
> > > The 33/66/100/133 values refer to the bus-clock speed at which the
> > > card is operating.  As is seen here (although a bit truncated --
> > > separate issue, I'll try to see if I can reproduce this on one of my
> > > HPQ rigs), the card is inserted into a PCI-X Mode-2 capable 133MHz
> > > (bus clock) slot.  When operating under this mode, each data-phase
> > > between two devices is divided into 2 sub-phases, effectively doubling
> > > the transfer-data-rate to 266Mhz.
> > 
> > I guess the proper terminology would be 266 MT/s (Mega
> > Transfers/second). Looking through the PSI_SIG PCI-X 2.0 marketing
> > blurbs, they use MHz a lot when referring to MT/S. So I would still
> > consider this to be a minor bug.  The user wants to know the transfer
> > rate, not the actual frequency of the bus.  Maybe just print out the
> > mode used instead, e.g., "PCI-X 266"?

Given PCI-X Mode-2 can run at different bus-clock speeds, how about
this as an alternative?

	PCI-X 266 (133Mhz)

it's a bit more descriptive than

	PCI-X Mode 2 (133Mhz)

then again, I don't want to beat this thing to death...

---

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index c488996..26f7e54 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -283,9 +283,9 @@ qla24xx_pci_info_str(struct scsi_qla_host *ha, char *str)
 	} else {
 		strcat(str, "-X ");
 		if (pci_bus & BIT_2)
-			strcat(str, "Mode 2");
+			strcat(str, "266");
 		else
-			strcat(str, "Mode 1");
+			strcat(str, "133");
 		strcat(str, " (");
 		strcat(str, pci_bus_modes[pci_bus & ~BIT_2]);
 	}

Re: Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

[Ulrich Windl]

On 31 Jul 2007 at 9:50, Andrew Vasquez wrote:

> > On Fri, 27 Jul 2007, Andrew Patterson wrote:
> > 
> > > On Thu, 2007-07-26 at 23:23 -0700, Andrew Vasquez wrote:
> > >
> > > > The 33/66/100/133 values refer to the bus-clock speed at which the
> > > > card is operating.  As is seen here (although a bit truncated --
> > > > separate issue, I'll try to see if I can reproduce this on one of my
> > > > HPQ rigs), the card is inserted into a PCI-X Mode-2 capable 133MHz
> > > > (bus clock) slot.  When operating under this mode, each data-phase
> > > > between two devices is divided into 2 sub-phases, effectively doubling
> > > > the transfer-data-rate to 266Mhz.
> > > 
> > > I guess the proper terminology would be 266 MT/s (Mega
> > > Transfers/second). Looking through the PSI_SIG PCI-X 2.0 marketing
> > > blurbs, they use MHz a lot when referring to MT/S. So I would still
> > > consider this to be a minor bug.  The user wants to know the transfer
> > > rate, not the actual frequency of the bus.  Maybe just print out the
> > > mode used instead, e.g., "PCI-X 266"?
> 
> Given PCI-X Mode-2 can run at different bus-clock speeds, how about
> this as an alternative?
> 
> 	PCI-X 266 (133Mhz)

To pick up the idea, why not "133" and "133x2" (DDR, Dual Data Rate)?

> 
> it's a bit more descriptive than
> 
> 	PCI-X Mode 2 (133Mhz)
> 
> then again, I don't want to beat this thing to death...
> 
> ---
> 
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index c488996..26f7e54 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -283,9 +283,9 @@ qla24xx_pci_info_str(struct scsi_qla_host *ha, char *str)
>  	} else {
>  		strcat(str, "-X ");
>  		if (pci_bus & BIT_2)
> -			strcat(str, "Mode 2");
> +			strcat(str, "266");
>  		else
> -			strcat(str, "Mode 1");
> +			strcat(str, "133");
>  		strcat(str, " (");
>  		strcat(str, pci_bus_modes[pci_bus & ~BIT_2]);
>  	}

Re: Q: PCI-X @ 266MHz on HP rx6600 (Qlogic 4Gb FC HBA)

[Ulrich Windl]

On 27 Jul 2007 at 9:46, Andrew Patterson wrote:

> On Thu, 2007-07-26 at 23:23 -0700, Andrew Vasquez wrote:
> > On Thu, 26 Jul 2007, Andrew Patterson wrote:
> > 
> > > On Thu, 2007-07-26 at 15:36 +0200, Ulrich Windl wrote:
> > > > Hi,
> > > > 
> > > > I have a question: The Qlogic ISP2422 chip is said to handle PCI-X 266MHz. So does 
> > > > the HP Itanium2 server rx6600. Basically that was the reason to select that 
> > > > server. The FC-HBA is in a 266 MHz capable slot. However when booting SLES10 SP1 
> > > > for IA64, the logs say:
> > 
> > There's a mixup here in terminology...  The QLA2460 card which you
> > have does in fact support 'PCI-X 266'...
> > 
> > > > <6>QLogic Fibre Channel HBA Driver
> > > > <6>GSI 49 (level, low) -> CPU 3 (0x0300) vector 51
> > > > <6>ACPI: PCI Interrupt 0000:0f:01.0[A] -> GSI 49 (level, low) -> IRQ 51
> > > > <6>qla2xxx 0000:0f:01.0: Found an ISP2422, irq 51, iobase 0xc0000000b0040000
> > > > [...]
> > > > <6>qla2xxx 0000:0f:01.0: LOOP UP detected (4 Gbps).
> > > > <6>qla2xxx 0000:0f:01.0: Topology - (F_Port), Host Loop address 0x0
> > > > <6>scsi0 : qla2xxx
> > > > <6>qla2xxx 0000:0f:01.0:
> > > > <4> QLogic Fibre Channel HBA Driver: 8.01.07-k3
> > > > <4>  QLogic HP AB378-60001 -
> > > > <4>  ISP2422: PCI-X Mode 2 (133 MH4.00.26 [IP]  @ 0000:0f:01.0 hdma+, host#=0, 
> > > > fw=4.00.26 [IP]
> > 
> > The 33/66/100/133 values refer to the bus-clock speed at which the
> > card is operating.  As is seen here (although a bit truncated --
> > separate issue, I'll try to see if I can reproduce this on one of my
> > HPQ rigs), the card is inserted into a PCI-X Mode-2 capable 133MHz
> > (bus clock) slot.  When operating under this mode, each data-phase
> > between two devices is divided into 2 sub-phases, effectively doubling
> > the transfer-data-rate to 266Mhz.
> 
> I guess the proper terminology would be 266 MT/s (Mega
> Transfers/second). Looking through the PSI_SIG PCI-X 2.0 marketing
> blurbs, they use MHz a lot when referring to MT/S. So I would still
> consider this to be a minor bug.  The user wants to know the transfer
> rate, not the actual frequency of the bus.  Maybe just print out the
> mode used instead, e.g., "PCI-X 266"?
[...]

To be concrete: In the Installation Manual for the rx6600 (P/N AB464-9001A), 
figure 1-1 ("I/O Subsystem Block Diagram") the names being used are "PCIx-66", 
"PCIx-133", and "PCIx267". However in the text following the text refers to "66 
MHz PCI/PCI-X slots" ("PCI/PCI-X 133 MHz", "PCI/PCI-X 266 MHz").

The Qlogic data sheet for the "ISP2422" also calls the bus interface "64-bit, PCI-
X 2.0 266-MHz DDR", and the document's subtitle is "Dual Port 4-Gbps Fibre Channel 
(FC) to PCI-X 2.0 266-MHz Controller".

Confusing?

Regards,
Ulrich

[PATCH] qla2xxx: allocate enough space for the full PCI descriptor.

[Andrew Vasquez]

Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
---

	On Thu, 26 Jul 2007, Andrew Vasquez wrote:

	> On Thu, 26 Jul 2007, Andrew Patterson wrote:
	> 
	> > On Thu, 2007-07-26 at 15:36 +0200, Ulrich Windl wrote:
	> > > Hi,
	> > > 
	> > > <6>QLogic Fibre Channel HBA Driver
	> > > <6>GSI 49 (level, low) -> CPU 3 (0x0300) vector 51
	> > > <6>ACPI: PCI Interrupt 0000:0f:01.0[A] -> GSI 49 (level, low) -> IRQ 51
	> > > <6>qla2xxx 0000:0f:01.0: Found an ISP2422, irq 51, iobase 0xc0000000b0040000
	> > > [...]
	> > > <6>qla2xxx 0000:0f:01.0: LOOP UP detected (4 Gbps).
	> > > <6>qla2xxx 0000:0f:01.0: Topology - (F_Port), Host Loop address 0x0
	> > > <6>scsi0 : qla2xxx
	> > > <6>qla2xxx 0000:0f:01.0:
	> > > <4> QLogic Fibre Channel HBA Driver: 8.01.07-k3
	> > > <4>  QLogic HP AB378-60001 -
	> > > <4>  ISP2422: PCI-X Mode 2 (133 MH4.00.26 [IP]  @ 0000:0f:01.0 hdma+, host#=0, 
	> > > fw=4.00.26 [IP]
	> 
	> The 33/66/100/133 values refer to the bus-clock speed at which the
	> card is operating.  As is seen here (although a bit truncated --
	> separate issue, I'll try to see if I can reproduce this on one of my
	> HPQ rigs),

	Ok, so what's happening here is the buffer passed in (pci_info)
	does not have bytes allocated (off by 3).

	James, please apply...

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 93c0c7e..acca898 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -1564,7 +1564,7 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
 	struct Scsi_Host *host;
 	scsi_qla_host_t *ha;
 	unsigned long	flags = 0;
-	char pci_info[20];
+	char pci_info[30];
 	char fw_str[30];
 	struct scsi_host_template *sht;