* [PATCH] do_sigaction: remove now unneeded recalc_sigpending()
@ 2007-08-02 22:37 Oleg Nesterov
2007-08-02 22:40 ` Roland McGrath
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2007-08-02 22:37 UTC (permalink / raw)
To: Andrew Morton; +Cc: Ingo Molnar, Roland McGrath, linux-kernel
With the recent changes, do_sigaction()->recalc_sigpending_and_wake() can
never clear TIF_SIGPENDING. Instead, it can set this flag and wake up the
thread without any reason. Harmless, but unneeded and wastes CPU.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- t/kernel/signal.c~ 2007-08-03 02:26:30.000000000 +0400
+++ t/kernel/signal.c 2007-08-03 02:28:50.000000000 +0400
@@ -2342,7 +2342,6 @@ int do_sigaction(int sig, struct k_sigac
rm_from_queue_full(&mask, &t->signal->shared_pending);
do {
rm_from_queue_full(&mask, &t->pending);
- recalc_sigpending_and_wake(t);
t = next_thread(t);
} while (t != current);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] do_sigaction: remove now unneeded recalc_sigpending()
2007-08-02 22:37 [PATCH] do_sigaction: remove now unneeded recalc_sigpending() Oleg Nesterov
@ 2007-08-02 22:40 ` Roland McGrath
0 siblings, 0 replies; 2+ messages in thread
From: Roland McGrath @ 2007-08-02 22:40 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Andrew Morton, Ingo Molnar, linux-kernel
> With the recent changes, do_sigaction()->recalc_sigpending_and_wake() can
> never clear TIF_SIGPENDING. Instead, it can set this flag and wake up the
> thread without any reason. Harmless, but unneeded and wastes CPU.
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
ACK. (We agreed months ago this was the thing to do.)
Thanks,
Roland
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-02 22:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-08-02 22:37 [PATCH] do_sigaction: remove now unneeded recalc_sigpending() Oleg Nesterov
2007-08-02 22:40 ` Roland McGrath
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®