Re: sdio: enhance IO_RW_EXTENDED support

[Pierre Ossman <drzeus-list@drzeus.cx>]

On Tue, 31 Jul 2007 16:36:30 +0100
David Vrabel <david.vrabel@csr.com> wrote:

> These three patches enhance the support for the SDIO IO_RW_EXTENDED
> command. The block size of functions is managed and the I/O ops
> (sdio_readsb() etc) are extended to handle arbitrary lengths of data
> (by using multiple commands).
> 
> I've not yet had a chance to test this stuff as I don't (yet) have
> the time to write a Bluetooth Type-A driver so these are posted as an
> example of the sort of API I'd expect.
> 

Thanks. These are some nice improvements. I do have one suggestion
though:

Could we design it so that sdio_io_rw_ext_helper() sets the block size
itself? That way most drivers wouldn't have to care about that detail
and the core would be free to choose optimal values.

I suspect that some transactions might require a certain block size.
But we could satisfy that by stating that any transfer small enough to
fit into one block will not be split up.

(PS. You might want to add [PATCH x/3] to your subjects so that the
order of the patches is crystal clear)

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org