* [PATCH] CFS: Mark print_cfs_stats static
@ 2007-07-20 18:44 Josh Triplett
2007-08-06 7:32 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Josh Triplett @ 2007-07-20 18:44 UTC (permalink / raw)
To: linux-kernel, akpm, linux-rt-users, mingo
sched_fair.c defines print_cfs_stats, and sched_debug.c uses it, but sched.c
includes both sched_fair.c and sched_debug.c, so all the references to
print_cfs_stats occur in the same compilation unit. Thus, mark
print_cfs_stats static.
Eliminates a sparse warning:
warning: symbol 'print_cfs_stats' was not declared. Should it be static?
Signed-off-by: Josh Triplett <josh@kernel.org>
---
This patch applies both to current Git and to 2.6.22.1-rt4.
kernel/sched_fair.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index 6971db0..8b954b9 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -1120,7 +1120,7 @@ struct sched_class fair_sched_class __read_mostly = {
};
#ifdef CONFIG_SCHED_DEBUG
-void print_cfs_stats(struct seq_file *m, int cpu, u64 now)
+static void print_cfs_stats(struct seq_file *m, int cpu, u64 now)
{
struct rq *rq = cpu_rq(cpu);
struct cfs_rq *cfs_rq;
--
1.5.2.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] CFS: Mark print_cfs_stats static
2007-07-20 18:44 [PATCH] CFS: Mark print_cfs_stats static Josh Triplett
@ 2007-08-06 7:32 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2007-08-06 7:32 UTC (permalink / raw)
To: josh, josht; +Cc: linux-kernel, akpm, linux-rt-users
* Josh Triplett <josh@kernel.org> wrote:
> sched_fair.c defines print_cfs_stats, and sched_debug.c uses it, but
> sched.c includes both sched_fair.c and sched_debug.c, so all the
> references to print_cfs_stats occur in the same compilation unit.
> Thus, mark print_cfs_stats static.
>
> Eliminates a sparse warning: warning: symbol 'print_cfs_stats' was not
> declared. Should it be static?
thanks, applied.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-06 7:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-20 18:44 [PATCH] CFS: Mark print_cfs_stats static Josh Triplett
2007-08-06 7:32 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®