From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Pavel Machek <pavel@ucw.cz>
Cc: ibm-acpi-devel@lists.sourceforge.net,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: refcounting problems with ibm_acpi but acpi=off
Date: Tue, 7 Aug 2007 20:55:16 -0300 [thread overview]
Message-ID: <20070807235516.GD2139@khazad-dum.debian.net> (raw)
In-Reply-To: <20070807214058.GA4413@elf.ucw.cz>
On Tue, 07 Aug 2007, Pavel Machek wrote:
> > > --- a/drivers/acpi/ibm_acpi.c
> > > +++ b/drivers/acpi/ibm_acpi.c
> > > @@ -2695,6 +2695,9 @@ static void acpi_ibm_exit(void)
> > > {
> > > int i;
> > >
> > > + if (acpi_disabled)
> > > + return;
> > > +
> > > for (i = ARRAY_SIZE(ibms) - 1; i >= 0; i--)
> > > ibm_exit(&ibms[i]);
> > >
> > >
> >
> > Indeed it is required, my bad.
> >
> > Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> >
> > Do you want me to forward a git patch to Len brown?
>
> Yes, please. Hmm, seems like at least asus_acpi is affected by same problem.
I just tested it, and thinkpad-acpi with all accepted patches by Len is not
affected by this problem, only some versions of ibm-acpi is. So there's
nothing to send to Len.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
prev parent reply other threads:[~2007-08-07 23:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-07 10:45 Pavel Machek
2007-08-07 11:20 ` Pavel Machek
2007-08-07 14:26 ` Henrique de Moraes Holschuh
2007-08-07 21:40 ` Pavel Machek
2007-08-07 23:55 ` Henrique de Moraes Holschuh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070807235516.GD2139@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®