From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: Larry.Finger@lwfinger.net, linux-kernel@vger.kernel.org
Subject: Re: Error message from device_rename in drivers/base/core.c
Date: Wed, 8 Aug 2007 11:33:59 +0200 [thread overview]
Message-ID: <20070808113359.71e77f49@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20070807.213724.27783161.davem@davemloft.net>
On Tue, 07 Aug 2007 21:37:24 -0700 (PDT),
David Miller <davem@davemloft.net> wrote:
> From: Larry Finger <Larry.Finger@lwfinger.net>
> Date: Tue, 07 Aug 2007 23:17:23 -0500
>
> > I am getting the following error message from drivers/base/core.c:
> >
> > net eth1: device_rename: sysfs_create_symlink failed (-17)
> >
> > Upon investigation, the call generating the error is renaming 'eth1' to 'eth1'. The following patch
> > suppresses the error.
>
> I think this check belongs in udev not in the kernel. Thankfully
> this message at least tells us it is happening, please don't
> remove it.
Hm, device_rename() could alternatively just return success if
dev->bus_id and new_name are the same.
>
> I'm pretty sure it's UDEV doing this, and it should not try to rename
> a netdevice to what it already is named.
But it shouldn't cause an error either :)
next prev parent reply other threads:[~2007-08-08 9:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 4:17 Larry Finger
2007-08-08 4:37 ` David Miller
2007-08-08 4:52 ` Larry Finger
2007-08-08 4:55 ` David Miller
2007-08-08 5:02 ` Larry Finger
2007-08-08 6:18 ` Sam Ravnborg
2007-08-08 9:33 ` Cornelia Huck [this message]
2007-08-08 12:23 ` Larry Finger
2007-08-08 13:46 ` Kay Sievers
2007-08-08 13:59 ` Larry Finger
2007-08-08 14:14 ` Kay Sievers
2007-08-08 15:19 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070808113359.71e77f49@gondolin.boeblingen.de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=Larry.Finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®