mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: LKML <linux-kernel@vger.kernel.org>
Subject: Error message from device_rename in drivers/base/core.c
Date: Tue, 07 Aug 2007 23:17:23 -0500	[thread overview]
Message-ID: <46B943D3.9020207@lwfinger.net> (raw)

I am getting the following error message from drivers/base/core.c:

net eth1: device_rename: sysfs_create_symlink failed (-17)

Upon investigation, the call generating the error is renaming 'eth1' to 'eth1'. The following patch 
suppresses the error.


Index: wireless-dev/drivers/base/core.c
===================================================================
--- wireless-dev.orig/drivers/base/core.c
+++ wireless-dev/drivers/base/core.c
@@ -1256,7 +1256,7 @@ int device_rename(struct device *dev, ch
  		sysfs_remove_link(&dev->class->subsys.kobj, old_device_name);
  		error = sysfs_create_link(&dev->class->subsys.kobj, &dev->kobj,
  					  dev->bus_id);
-		if (error) {
+		if (error && memcmp(dev->bus_id, new_name, sizeof(new_name))) {
  			/* Uh... how to unravel this if restoring can fail? */
  			dev_err(dev, "%s: sysfs_create_symlink failed (%d)\n",
  				__FUNCTION__, error);


Larry

             reply	other threads:[~2007-08-08  4:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-08  4:17 Larry Finger [this message]
2007-08-08  4:37 ` David Miller
2007-08-08  4:52   ` Larry Finger
2007-08-08  4:55     ` David Miller
2007-08-08  5:02       ` Larry Finger
2007-08-08  6:18     ` Sam Ravnborg
2007-08-08  9:33   ` Cornelia Huck
2007-08-08 12:23     ` Larry Finger
2007-08-08 13:46       ` Kay Sievers
2007-08-08 13:59         ` Larry Finger
2007-08-08 14:14           ` Kay Sievers
2007-08-08 15:19             ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B943D3.9020207@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®