mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Dmitry Adamushko <dmitry.adamushko@gmail.com>
Cc: Mitchell Erblich <erblichs@earthlink.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Question: RT schedular : task_tick_rt(struct rq *rq, struct task_struct *p) : decreases overhead when rq->nr_running == 1
Date: Thu, 9 Aug 2007 10:26:56 +0200	[thread overview]
Message-ID: <20070809082656.GA21973@elte.hu> (raw)
In-Reply-To: <b647ffbd0708090111r50d29dbp779e014db1a63296@mail.gmail.com>


* Dmitry Adamushko <dmitry.adamushko@gmail.com> wrote:

> I guess, the following thing would do a better job:
> 
> - we do need reschedule() _only_ if there are other task on the _same_ 
> queue (for this prio level) :

ah, indeed.

> --- kernel/sched_rt-prev.c      2007-08-09 09:55:10.000000000 +0200
> +++ kernel/sched_rt.c   2007-08-09 09:58:53.000000000 +0200
> @@ -207,6 +207,11 @@ static void task_tick_rt(struct rq *rq,
>                 return;
> 
>         p->time_slice = static_prio_timeslice(p->static_prio);
> +
> +       /* We are the only element on the queue. */
> +       if (p->run_list.prev == p->run_list.next)
> +               return;
> +

i've applied your patch - could you please send a SOB line?

	Ingo

  reply	other threads:[~2007-08-09  8:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-07 22:54 Mitchell Erblich
2007-08-08 12:34 ` Ingo Molnar
2007-08-09  8:11   ` Dmitry Adamushko
2007-08-09  8:26     ` Ingo Molnar [this message]
2007-08-09  8:36       ` Ingo Molnar
2007-08-09  8:39         ` Dmitry Adamushko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070809082656.GA21973@elte.hu \
    --to=mingo@elte.hu \
    --cc=dmitry.adamushko@gmail.com \
    --cc=erblichs@earthlink.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®