From: miklos@szeredi.hu
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org
Cc: Christoph Hellwig <hch@infradead.org>
Subject: [patch 4/9] exec: remove unnecessary check for MNT_NOEXEC
Date: Thu, 09 Aug 2007 11:20:50 +0200 [thread overview]
Message-ID: <20070809092502.976382639@szeredi.hu> (raw)
In-Reply-To: <20070809092046.656183199@szeredi.hu>
[-- Attachment #1: mnt_noexec_cleanup.patch --]
[-- Type: text/plain, Size: 1038 bytes --]
From: Miklos Szeredi <mszeredi@suse.cz>
vfs_permission(MAY_EXEC) checks if the filesystem is mounted with
"noexec", so there's no need to repeat this check in sys_uselib() and
open_exec().
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
---
Index: linux/fs/exec.c
===================================================================
--- linux.orig/fs/exec.c 2007-08-09 11:01:54.000000000 +0200
+++ linux/fs/exec.c 2007-08-09 11:04:24.000000000 +0200
@@ -113,9 +113,6 @@ asmlinkage long sys_uselib(const char __
if (error)
goto out;
- error = -EACCES;
- if (nd.mnt->mnt_flags & MNT_NOEXEC)
- goto exit;
error = -EINVAL;
if (!S_ISREG(nd.dentry->d_inode->i_mode))
goto exit;
@@ -659,8 +656,7 @@ struct file *open_exec(const char *name)
if (!err) {
struct inode *inode = nd.dentry->d_inode;
file = ERR_PTR(-EACCES);
- if (!(nd.mnt->mnt_flags & MNT_NOEXEC) &&
- S_ISREG(inode->i_mode)) {
+ if (S_ISREG(inode->i_mode)) {
int err = vfs_permission(&nd, MAY_EXEC);
file = ERR_PTR(err);
if (!err) {
--
next prev parent reply other threads:[~2007-08-09 9:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 9:20 [patch 0/9] assorted fixes and cleanups miklos
2007-08-09 9:20 ` [patch 1/9] unprivileged mounts: fix subtype handling miklos
2007-08-09 9:20 ` [patch 2/9] VFS: check nanoseconds in utimensat miklos
2007-08-09 9:20 ` [patch 3/9] fix execute checking in permission() miklos
2007-08-09 9:20 ` miklos [this message]
2007-08-09 9:20 ` [patch 5/9] fuse: fix setting i_mode bits miklos
2007-08-09 9:20 ` [patch 6/9] fuse: clean up execute permission checking miklos
2007-08-09 9:20 ` [patch 7/9] clean out unused code in dentry pruning miklos
2007-08-09 9:20 ` [patch 8/9] UML: remove unnecessary hostfs_getattr() miklos
2007-08-09 9:20 ` [patch 9/9] fix warnings is revoked_inode.c miklos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070809092502.976382639@szeredi.hu \
--to=miklos@szeredi.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®