From: miklos@szeredi.hu
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org
Cc: Nick Piggin <npiggin@suse.de>
Subject: [patch 9/9] fix warnings is revoked_inode.c
Date: Thu, 09 Aug 2007 11:20:55 +0200 [thread overview]
Message-ID: <20070809092528.169389391@szeredi.hu> (raw)
In-Reply-To: <20070809092046.656183199@szeredi.hu>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: mm_fix_bothersome_warning.patch --]
[-- Type: text/plain, Size: 1549 bytes --]
From: Miklos Szeredi <mszeredi@suse.cz>
Fix following warnings introduced by
fs-introduce-write_begin-write_end-and-perform_write-aops-revoke.patch
fs/revoked_inode.c:381: warning: ‘revoked_write_begin’ defined but not used
fs/revoked_inode.c:388: warning: ‘revoked_write_end’ defined but not used
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
---
Index: linux/fs/revoked_inode.c
===================================================================
--- linux.orig/fs/revoked_inode.c 2007-08-09 11:01:55.000000000 +0200
+++ linux/fs/revoked_inode.c 2007-08-09 11:04:37.000000000 +0200
@@ -363,18 +363,6 @@ static int revoked_writepage(struct page
return -EIO;
}
-static int revoked_prepare_write(struct file *file, struct page *page,
- unsigned from, unsigned to)
-{
- return -EIO;
-}
-
-static int revoked_commit_write(struct file *file, struct page *page,
- unsigned from, unsigned to)
-{
- return -EIO;
-}
-
static int revoked_write_begin(struct file *file, struct address_space *mapping,
loff_t pos, unsigned len, unsigned flags,
struct page **pagep, void **fsdata)
@@ -399,8 +387,8 @@ static ssize_t revoked_direct_IO(int rw,
static const struct address_space_operations revoked_aops = {
.readpage = revoked_readpage,
.writepage = revoked_writepage,
- .prepare_write = revoked_prepare_write,
- .commit_write = revoked_commit_write,
+ .write_begin = revoked_write_begin,
+ .write_end = revoked_write_end,
.direct_IO = revoked_direct_IO,
};
--
prev parent reply other threads:[~2007-08-09 9:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 9:20 [patch 0/9] assorted fixes and cleanups miklos
2007-08-09 9:20 ` [patch 1/9] unprivileged mounts: fix subtype handling miklos
2007-08-09 9:20 ` [patch 2/9] VFS: check nanoseconds in utimensat miklos
2007-08-09 9:20 ` [patch 3/9] fix execute checking in permission() miklos
2007-08-09 9:20 ` [patch 4/9] exec: remove unnecessary check for MNT_NOEXEC miklos
2007-08-09 9:20 ` [patch 5/9] fuse: fix setting i_mode bits miklos
2007-08-09 9:20 ` [patch 6/9] fuse: clean up execute permission checking miklos
2007-08-09 9:20 ` [patch 7/9] clean out unused code in dentry pruning miklos
2007-08-09 9:20 ` [patch 8/9] UML: remove unnecessary hostfs_getattr() miklos
2007-08-09 9:20 ` miklos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070809092528.169389391@szeredi.hu \
--to=miklos@szeredi.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®