mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: patches@x86-64.org, linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: [PATCH] [1/4] x86_64: Fail dma_alloc_coherent on dma less devices
Date: Wed, 15 Aug 2007 02:40:34 +0200 (CEST)	[thread overview]
Message-ID: <20070815004034.4AB7814DC8@wotan.suse.de> (raw)
In-Reply-To: <20070815240.194452000@suse.de>


This should fix an oops with PCMCIA PATA devices

http://bugzilla.kernel.org/show_bug.cgi?id=8424

This is not a full fix for the problem, but probably
still the right thing to do.

Signed-off-by: Andi Kleen <ak@suse.de>

---
 arch/x86_64/kernel/pci-dma.c |    4 ++++
 1 file changed, 4 insertions(+)

Index: linux/arch/x86_64/kernel/pci-dma.c
===================================================================
--- linux.orig/arch/x86_64/kernel/pci-dma.c
+++ linux/arch/x86_64/kernel/pci-dma.c
@@ -82,6 +82,10 @@ dma_alloc_coherent(struct device *dev, s
 	if (dma_mask == 0)
 		dma_mask = DMA_32BIT_MASK;
 
+	/* Device not DMA able */
+	if (dev->dma_mask == NULL)
+		return NULL;
+
 	/* Don't invoke OOM killer */
 	gfp |= __GFP_NORETRY;
 

  reply	other threads:[~2007-08-15  0:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-15  0:40 [PATCH] [0/4] More late merge bug fixes for 2.6.23 Andi Kleen
2007-08-15  0:40 ` Andi Kleen [this message]
2007-08-18 17:22   ` [PATCH] [1/4] x86_64: Fail dma_alloc_coherent on dma less devices Linus Torvalds
2007-08-18 19:03     ` Andi Kleen
2007-08-20  9:46       ` Takashi Iwai
2007-08-15  0:40 ` [PATCH] [2/4] x86_64: Fix to keep watchdog disabled by default for i386/x86_64 Andi Kleen
2007-08-15  0:40 ` [PATCH] [3/4] x86_64: Change PMDS invocation to single macro Andi Kleen
2007-08-15 12:29   ` Clemens Koller
2007-08-15 13:57     ` Andi Kleen
2007-08-15  0:40 ` [PATCH] [4/4] x86_64: Check for .cfi_rel_offset in CFI probe Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070815004034.4AB7814DC8@wotan.suse.de \
    --to=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@x86-64.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®