* [PATCH] __group_complete_signal: eliminate unneeded wakeup of ->group_exit_task
@ 2007-08-17 16:47 Oleg Nesterov
0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2007-08-17 16:47 UTC (permalink / raw)
To: Andrew Morton; +Cc: Roland McGrath, linux-kernel
Cleanup. __group_complete_signal() wakes up ->group_exit_task twice. The second
wakeup's state includes TASK_UNINTERRUPTIBLE, which is not very appropriate.
Change the code to pass the "correct" argument to signal_wake_up() and kill now
unneeded wake_up_process().
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- t/kernel/signal.c~2_GCS_NOWAKEUP 2007-08-12 19:48:26.000000000 +0400
+++ t/kernel/signal.c 2007-08-17 20:23:59.000000000 +0400
@@ -911,8 +911,7 @@ __group_complete_signal(int sig, struct
do {
sigaddset(&t->pending.signal, SIGKILL);
signal_wake_up(t, 1);
- t = next_thread(t);
- } while (t != p);
+ } while_each_thread(p, t);
return;
}
@@ -930,13 +929,11 @@ __group_complete_signal(int sig, struct
rm_from_queue(SIG_KERNEL_STOP_MASK, &p->signal->shared_pending);
p->signal->group_stop_count = 0;
p->signal->group_exit_task = t;
- t = p;
+ p = t;
do {
p->signal->group_stop_count++;
- signal_wake_up(t, 0);
- t = next_thread(t);
- } while (t != p);
- wake_up_process(p->signal->group_exit_task);
+ signal_wake_up(t, t == p);
+ } while_each_thread(p, t);
return;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-08-17 16:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-08-17 16:47 [PATCH] __group_complete_signal: eliminate unneeded wakeup of ->group_exit_task Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®