* [PATCH] IRDA: Avoid a label defined but not used warning in irda_init()
@ 2007-08-17 21:22 Jesper Juhl
2007-08-21 7:11 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jesper Juhl @ 2007-08-17 21:22 UTC (permalink / raw)
To: Samuel Ortiz
Cc: Linux Kernel Mailing List, Dag Brattli, Jean Tourrilhes, Jesper Juhl
Hi,
Easily avoidable compiler warnings bug me.
Building irmod without CONFIG_SYSCTL currently results in :
net/irda/irmod.c:132: warning: label 'out_err_2' defined but not used
But that can easily be avoided by simply moving the label inside
the existing "#ifdef CONFIG_SYSCTL" one line above it.
This patch moves the label and buys us one less warning with no
ill effects.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
net/irda/irmod.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/irda/irmod.c b/net/irda/irmod.c
index 1900937..8ba703d 100644
--- a/net/irda/irmod.c
+++ b/net/irda/irmod.c
@@ -128,8 +128,8 @@ static int __init irda_init(void)
out_err_3:
#ifdef CONFIG_SYSCTL
irda_sysctl_unregister();
-#endif
out_err_2:
+#endif
#ifdef CONFIG_PROC_FS
irda_proc_unregister();
#endif
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] IRDA: Avoid a label defined but not used warning in irda_init()
2007-08-17 21:22 [PATCH] IRDA: Avoid a label defined but not used warning in irda_init() Jesper Juhl
@ 2007-08-21 7:11 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-08-21 7:11 UTC (permalink / raw)
To: jesper.juhl; +Cc: samuel, linux-kernel, dagb, jt
From: Jesper Juhl <jesper.juhl@gmail.com>
Date: Fri, 17 Aug 2007 23:22:33 +0200
> Hi,
>
> Easily avoidable compiler warnings bug me.
>
>
> Building irmod without CONFIG_SYSCTL currently results in :
> net/irda/irmod.c:132: warning: label 'out_err_2' defined but not used
>
> But that can easily be avoided by simply moving the label inside
> the existing "#ifdef CONFIG_SYSCTL" one line above it.
>
> This patch moves the label and buys us one less warning with no
> ill effects.
>
>
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Applied, thanks Jesper.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-21 7:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-08-17 21:22 [PATCH] IRDA: Avoid a label defined but not used warning in irda_init() Jesper Juhl
2007-08-21 7:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®