From: Oleg Nesterov <oleg@tv-sign.ru>
To: Cliff Wickman <cpw@sgi.com>
Cc: akpm@linux-foundation.org, ego@in.ibm.com, mingo@elte.hu,
vatsa@in.ibm.com, pj@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] hotplug cpu: migrate a task within its cpuset
Date: Sat, 25 Aug 2007 15:18:28 +0400 [thread overview]
Message-ID: <20070825111828.GA246@tv-sign.ru> (raw)
In-Reply-To: <20070824221806.GA3602@sgi.com>
On 08/24, Cliff Wickman wrote:
>
> @@ -5091,6 +5092,17 @@ restart:
> if (dest_cpu == NR_CPUS)
> dest_cpu = any_online_cpu(p->cpus_allowed);
>
> + /* try to stay on the same cpuset */
> + if (dest_cpu == NR_CPUS) {
> + /*
> + * The cpuset_cpus_allowed_lock() variant of
> + * cpuset_cpus_allowed() will not block
> + * It must be called within calls to cpuset_lock/cpuset_unlock.
> + */
> + p->cpus_allowed = cpuset_cpus_allowed_lock(p);
> + dest_cpu = any_online_cpu(p->cpus_allowed);
Ugh, didn't notice while reading this patch.
We shouldn't change ->cpus_allowed without rq->lock. Please look what
the current code does in "/* No more Mr. Nice Guy. */" case.
Oleg.
next prev parent reply other threads:[~2007-08-25 11:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-24 22:18 Cliff Wickman
2007-08-24 22:54 ` Andrew Morton
2007-08-25 9:47 ` Oleg Nesterov
2007-08-26 0:16 ` Gautham R Shenoy
2007-08-26 0:47 ` Rusty Russell
2007-08-26 8:09 ` Andrew Morton
2007-08-27 7:01 ` Rusty Russell
2007-08-25 9:58 ` Oleg Nesterov
2007-08-25 11:18 ` Oleg Nesterov [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-05-23 21:29 Oleg Nesterov
2007-05-23 22:56 ` Cliff Wickman
2007-05-23 23:32 ` Oleg Nesterov
2007-05-21 20:08 Cliff Wickman
2007-05-23 17:43 ` Andrew Morton
2007-05-24 7:56 ` Ingo Molnar
2007-05-29 19:32 ` Andrew Morton
2007-03-09 19:39 Cliff Wickman
2007-03-09 23:58 ` Nathan Lynch
2007-03-15 0:36 ` Robin Holt
2007-03-15 7:32 ` Nathan Lynch
2007-03-10 9:19 ` Ingo Molnar
2007-03-10 15:51 ` Nathan Lynch
2007-03-10 17:08 ` Ingo Molnar
2007-03-07 14:24 Cliff Wickman
2007-03-07 18:25 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070825111828.GA246@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=cpw@sgi.com \
--cc=ego@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pj@sgi.com \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®