From: cpw@sgi.com (Cliff Wickman)
To: linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] hotplug cpu: migrate a task within its cpuset
Date: Wed, 07 Mar 2007 08:24:44 -0600 [thread overview]
Message-ID: <45EECB2C.mailxEK515UYJW@eag09.americas.sgi.com> (raw)
From: Cliff Wickman <cpw@sgi.com>
When a cpu is disabled, move_task_off_dead_cpu() is called for tasks
that have been running on that cpu.
Currently, such a task is migrated:
1) to any cpu on the same node as the disabled cpu, which is both online
and among that task's cpus_allowed
2) to any cpu which is both online and among that task's cpus_allowed
But the task's cpus_allowed may have been a single cpu.
This patch would insert a preference to migrate such a task to a cpu within
its cpuset (and set its cpus_allowed to its cpuset).
With this patch, migrate the task to:
1) to any cpu on the same node as the disabled cpu, which is both online
and among that task's cpus_allowed
2) to any online cpu within the task's cpuset
3) to any cpu which is both online and among that task's cpus_allowed
Diffed against 2.6.16.37
Signed-off-by: Cliff Wickman <cpw@sgi.com>
---
kernel/sched.c | 6 ++++++
1 file changed, 6 insertions(+)
Index: linux/kernel/sched.c
===================================================================
--- linux.orig/kernel/sched.c
+++ linux/kernel/sched.c
@@ -4602,6 +4602,12 @@ static void move_task_off_dead_cpu(int d
if (dest_cpu == NR_CPUS)
dest_cpu = any_online_cpu(tsk->cpus_allowed);
+ /* try to stay on the same cpuset */
+ if (dest_cpu == NR_CPUS) {
+ tsk->cpus_allowed = cpuset_cpus_allowed(tsk);
+ dest_cpu = any_online_cpu(tsk->cpus_allowed);
+ }
+
/* No more Mr. Nice Guy. */
if (dest_cpu == NR_CPUS) {
cpus_setall(tsk->cpus_allowed);
next reply other threads:[~2007-03-07 14:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 14:24 Cliff Wickman [this message]
2007-03-07 18:25 ` Randy Dunlap
2007-03-09 19:39 Cliff Wickman
2007-03-09 23:58 ` Nathan Lynch
2007-03-15 0:36 ` Robin Holt
2007-03-15 7:32 ` Nathan Lynch
2007-03-10 9:19 ` Ingo Molnar
2007-03-10 15:51 ` Nathan Lynch
2007-03-10 17:08 ` Ingo Molnar
2007-05-21 20:08 Cliff Wickman
2007-05-23 17:43 ` Andrew Morton
2007-05-24 7:56 ` Ingo Molnar
2007-05-29 19:32 ` Andrew Morton
2007-05-23 21:29 Oleg Nesterov
2007-05-23 22:56 ` Cliff Wickman
2007-05-23 23:32 ` Oleg Nesterov
2007-08-24 22:18 Cliff Wickman
2007-08-24 22:54 ` Andrew Morton
2007-08-25 9:47 ` Oleg Nesterov
2007-08-26 0:16 ` Gautham R Shenoy
2007-08-26 0:47 ` Rusty Russell
2007-08-26 8:09 ` Andrew Morton
2007-08-27 7:01 ` Rusty Russell
2007-08-25 9:58 ` Oleg Nesterov
2007-08-25 11:18 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45EECB2C.mailxEK515UYJW@eag09.americas.sgi.com \
--to=cpw@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®