From: m.kozlowski@tuxland.pl
To: airlied@linux.ie, akpm@linux-foundation.org
Cc: dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [PATCH 15/23] i915_irq.c: drm_calloc to drm_zalloc and bugfix
Date: Mon, 27 Aug 2007 22:58:05 +0200 [thread overview]
Message-ID: <20070827211355.073460000@tuxland.pl> (raw)
In-Reply-To: <20070827205750.514001000@tuxland.pl>
[-- Attachment #1: i915_irq.diff --]
[-- Type: text/plain, Size: 917 bytes --]
This patch does drm_calloc to drm_zalloc conversion. Also it
seems that unpatched version allocated wrong nr of bytes.
drm_i915_vbl_swap_t *vbl_swap;
...
sizeof(vbl_swap) vs. sizeof(*vbl_swap)
No?
Please review.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
drivers/char/drm/i915_irq.c | 15749 -> 15746 (-3 bytes)
drivers/char/drm/i915_irq.o | 128940 -> 128856 (-84 bytes)
drivers/char/drm/i915_irq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- linux-2.6.23-rc3-mm1.orig/drivers/char/drm/i915_irq.c
+++ linux-2.6.23-rc3-mm1/drivers/char/drm/i915_irq.c
@@ -541,8 +541,7 @@ int i915_vblank_swap(DRM_IOCTL_ARGS)
return DRM_ERR(EBUSY);
}
- vbl_swap = drm_calloc(1, sizeof(vbl_swap), DRM_MEM_DRIVER);
-
+ vbl_swap = drm_zalloc(sizeof(*vbl_swap), DRM_MEM_DRIVER);
if (!vbl_swap) {
DRM_ERROR("Failed to allocate memory to queue swap\n");
return DRM_ERR(ENOMEM);
--
next prev parent reply other threads:[~2007-08-27 21:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-27 20:57 [PATCH 00/23] drm: introduce drm_zalloc m.kozlowski
2007-08-27 20:57 ` [PATCH 01/23] introduce drm_zalloc as a drm_alloc + memset replacement m.kozlowski
2007-08-27 21:36 ` Mariusz Kozlowski
2007-08-28 19:58 ` Ian Romanick
2007-08-27 20:57 ` [PATCH 02/23] drm_agpsupport.c: drm_alloc + memset to drm_zalloc m.kozlowski
2007-08-27 20:57 ` [PATCH 03/23] drm_auth.c: " m.kozlowski
2007-08-27 20:57 ` [PATCH 04/23] drm_bufs.c: drm_alloc + memset to drm_alloc m.kozlowski
2007-08-27 20:57 ` [PATCH 05/23] drm_dma.c: drm_alloc + memset to drm_zalloc m.kozlowski
2007-08-27 20:57 ` [PATCH 06/23] drm_drawable.c: drm_calloc " m.kozlowski
2007-08-27 20:57 ` [PATCH 07/23] drm_fops.c: drm_alloc + memset " m.kozlowski
2007-08-27 20:57 ` [PATCH 08/23] drm_irq.c: " m.kozlowski
2007-08-27 20:57 ` [PATCH 09/23] drm_scatter.c: drm_alloc + memset to drm_alloc m.kozlowski
2007-08-27 20:58 ` [PATCH 10/23] drm_sman.c: drm_calloc to drm_zalloc m.kozlowski
2007-08-27 20:58 ` [PATCH 11/23] drm_stub.c: " m.kozlowski
2007-08-27 20:58 ` [PATCH 12/23] i810_dma.c: drm_alloc + memset " m.kozlowski
2007-08-27 20:58 ` [PATCH 13/23] i830_dma.c: " m.kozlowski
2007-08-27 20:58 ` [PATCH 14/23] i915_dma.c: " m.kozlowski
2007-08-27 20:58 ` m.kozlowski [this message]
2007-08-27 20:58 ` [PATCH 16/23] i915_mem.c: " m.kozlowski
2007-08-27 20:58 ` [PATCH 17/23] mga_dma.c: " m.kozlowski
2007-08-27 20:58 ` [PATCH 18/23] r128_cce.c: " m.kozlowski
2007-08-27 20:58 ` [PATCH 19/23] radeon_cp.c: " m.kozlowski
2007-08-27 20:58 ` [PATCH 20/23] radeon_mem.c: " m.kozlowski
2007-08-27 20:58 ` [PATCH 21/23] savage_bci.c: drm_alloc + memset to drm_zalloc and cleanup m.kozlowski
2007-08-27 20:58 ` [PATCH 22/23] sis_drv.c: drm_calloc to drm_zalloc m.kozlowski
2007-08-27 20:58 ` [PATCH 23/23] via_map.c: " m.kozlowski
2007-08-28 20:08 ` [PATCH 00/23] drm: introduce drm_zalloc Christoph Hellwig
2007-08-28 20:50 ` Dave Airlie
2007-08-30 16:20 ` Kristian Høgsberg
2007-08-30 16:24 ` Christoph Hellwig
2007-08-30 23:20 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070827211355.073460000@tuxland.pl \
--to=m.kozlowski@tuxland.pl \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=dri-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®