mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: m.kozlowski@tuxland.pl
To: airlied@linux.ie, akpm@linux-foundation.org
Cc: dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [PATCH 17/23] mga_dma.c: drm_alloc + memset to drm_zalloc
Date: Mon, 27 Aug 2007 22:58:07 +0200	[thread overview]
Message-ID: <20070827211356.744586000@tuxland.pl> (raw)
In-Reply-To: <20070827205750.514001000@tuxland.pl>

[-- Attachment #1: mga_dma.diff --]
[-- Type: text/plain, Size: 1764 bytes --]

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>

 drivers/char/drm/mga_dma.c | 30418 -> 30253 (-165 bytes)
 drivers/char/drm/mga_dma.o | 140668 -> 140304 (-364 bytes)

 drivers/char/drm/mga_dma.c |   14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

--- linux-2.6.23-rc3-mm1.orig/drivers/char/drm/mga_dma.c
+++ linux-2.6.23-rc3-mm1/drivers/char/drm/mga_dma.c
@@ -254,23 +254,20 @@ static int mga_freelist_init(struct drm_
 	int i;
 	DRM_DEBUG("count=%d\n", dma->buf_count);

-	dev_priv->head = drm_alloc(sizeof(drm_mga_freelist_t), DRM_MEM_DRIVER);
-	if (dev_priv->head == NULL)
+	dev_priv->head = drm_zalloc(sizeof(drm_mga_freelist_t), DRM_MEM_DRIVER);
+	if (!dev_priv->head)
 		return DRM_ERR(ENOMEM);

-	memset(dev_priv->head, 0, sizeof(drm_mga_freelist_t));
 	SET_AGE(&dev_priv->head->age, MGA_BUFFER_USED, 0);

 	for (i = 0; i < dma->buf_count; i++) {
 		buf = dma->buflist[i];
 		buf_priv = buf->dev_private;

-		entry = drm_alloc(sizeof(drm_mga_freelist_t), DRM_MEM_DRIVER);
-		if (entry == NULL)
+		entry = drm_zalloc(sizeof(drm_mga_freelist_t), DRM_MEM_DRIVER);
+		if (!entry)
 			return DRM_ERR(ENOMEM);

-		memset(entry, 0, sizeof(drm_mga_freelist_t));
-
 		entry->next = dev_priv->head->next;
 		entry->prev = dev_priv->head;
 		SET_AGE(&entry->age, MGA_BUFFER_FREE, 0);
@@ -397,12 +394,11 @@ int mga_driver_load(struct drm_device *
 {
 	drm_mga_private_t *dev_priv;

-	dev_priv = drm_alloc(sizeof(drm_mga_private_t), DRM_MEM_DRIVER);
+	dev_priv = drm_zalloc(sizeof(drm_mga_private_t), DRM_MEM_DRIVER);
 	if (!dev_priv)
 		return DRM_ERR(ENOMEM);

 	dev->dev_private = (void *)dev_priv;
-	memset(dev_priv, 0, sizeof(drm_mga_private_t));

 	dev_priv->usec_timeout = MGA_DEFAULT_USEC_TIMEOUT;
 	dev_priv->chipset = flags;

--

  parent reply	other threads:[~2007-08-27 21:20 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-27 20:57 [PATCH 00/23] drm: introduce drm_zalloc m.kozlowski
2007-08-27 20:57 ` [PATCH 01/23] introduce drm_zalloc as a drm_alloc + memset replacement m.kozlowski
2007-08-27 21:36   ` Mariusz Kozlowski
2007-08-28 19:58   ` Ian Romanick
2007-08-27 20:57 ` [PATCH 02/23] drm_agpsupport.c: drm_alloc + memset to drm_zalloc m.kozlowski
2007-08-27 20:57 ` [PATCH 03/23] drm_auth.c: " m.kozlowski
2007-08-27 20:57 ` [PATCH 04/23] drm_bufs.c: drm_alloc + memset to drm_alloc m.kozlowski
2007-08-27 20:57 ` [PATCH 05/23] drm_dma.c: drm_alloc + memset to drm_zalloc m.kozlowski
2007-08-27 20:57 ` [PATCH 06/23] drm_drawable.c: drm_calloc " m.kozlowski
2007-08-27 20:57 ` [PATCH 07/23] drm_fops.c: drm_alloc + memset " m.kozlowski
2007-08-27 20:57 ` [PATCH 08/23] drm_irq.c: " m.kozlowski
2007-08-27 20:57 ` [PATCH 09/23] drm_scatter.c: drm_alloc + memset to drm_alloc m.kozlowski
2007-08-27 20:58 ` [PATCH 10/23] drm_sman.c: drm_calloc to drm_zalloc m.kozlowski
2007-08-27 20:58 ` [PATCH 11/23] drm_stub.c: " m.kozlowski
2007-08-27 20:58 ` [PATCH 12/23] i810_dma.c: drm_alloc + memset " m.kozlowski
2007-08-27 20:58 ` [PATCH 13/23] i830_dma.c: " m.kozlowski
2007-08-27 20:58 ` [PATCH 14/23] i915_dma.c: " m.kozlowski
2007-08-27 20:58 ` [PATCH 15/23] i915_irq.c: drm_calloc to drm_zalloc and bugfix m.kozlowski
2007-08-27 20:58 ` [PATCH 16/23] i915_mem.c: drm_alloc + memset to drm_zalloc m.kozlowski
2007-08-27 20:58 ` m.kozlowski [this message]
2007-08-27 20:58 ` [PATCH 18/23] r128_cce.c: " m.kozlowski
2007-08-27 20:58 ` [PATCH 19/23] radeon_cp.c: " m.kozlowski
2007-08-27 20:58 ` [PATCH 20/23] radeon_mem.c: " m.kozlowski
2007-08-27 20:58 ` [PATCH 21/23] savage_bci.c: drm_alloc + memset to drm_zalloc and cleanup m.kozlowski
2007-08-27 20:58 ` [PATCH 22/23] sis_drv.c: drm_calloc to drm_zalloc m.kozlowski
2007-08-27 20:58 ` [PATCH 23/23] via_map.c: " m.kozlowski
2007-08-28 20:08 ` [PATCH 00/23] drm: introduce drm_zalloc Christoph Hellwig
2007-08-28 20:50   ` Dave Airlie
2007-08-30 16:20     ` Kristian Høgsberg
2007-08-30 16:24       ` Christoph Hellwig
2007-08-30 23:20         ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070827211356.744586000@tuxland.pl \
    --to=m.kozlowski@tuxland.pl \
    --cc=airlied@linux.ie \
    --cc=akpm@linux-foundation.org \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®