From: Andrey Borzenkov <arvidjaar@mail.ru>
To: Kay Sievers <kay.sievers@vrfy.org>,
anssi.hannula@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: sysfs change of input/event devices in 2.6.23rc breaks udev
Date: Mon, 10 Sep 2007 06:40:57 +0400 [thread overview]
Message-ID: <20070910024057.D7D91411ABE@smtp03.mtu.ru> (raw)
In-Reply-To: <3ae72650709091603o57c976d1q8a1b5492ef041186@mail.gmail.com>
Kay Sievers wrote:
> On 9/8/07, Anssi Hannula <anssi.hannula@gmail.com> wrote:
>> There seem to be changes in sysfs input structure between 2.6.22 and
>> 2.6.23-rc5 which cause some breakage.
>>
>> With 2.6.22:
>>
>> > # LC_ALL=C ls -l /sys/class/input/input4
>> > total 0
>> > drwxr-xr-x 2 root root 0 Sep 8 12:51 capabilities/
>> > lrwxrwxrwx 1 root root 0 Sep 8 19:48 device ->
>> > ../../../devices/platform/pcspkr/
>> > drwxr-xr-x 2 root root 0 Sep 8 12:51 event4/
>> > drwxr-xr-x 2 root root 0 Sep 8 12:51 id/
>> > -r--r--r-- 1 root root 4096 Sep 8 19:48 modalias
>> > -r--r--r-- 1 root root 4096 Sep 8 19:48 name
>> > -r--r--r-- 1 root root 4096 Sep 8 19:48 phys
>> > lrwxrwxrwx 1 root root 0 Sep 8 19:48 subsystem ->
>> > ../../../class/input/
>> > --w------- 1 root root 4096 Sep 8 19:48 uevent
>> > -r--r--r-- 1 root root 4096 Sep 8 19:48 uniq
>>
>> > # ls -l /sys/class/input/event4
>> > lrwxrwxrwx 1 root root 0 Sep 8 19:48 /sys/class/input/event4 ->
>> > ../../class/input/input4/event4/
>> > # ls -l /sys/class/input/event4/
>> > total 0
>> > -r--r--r-- 1 root root 4096 Sep 8 19:58 dev
>> > lrwxrwxrwx 1 root root 0 Sep 8 19:58 device ->
>> > ../../../../devices/platform/pcspkr/
>> > lrwxrwxrwx 1 root root 0 Sep 8 19:58 subsystem ->
>> > ../../../../class/input/
>> > --w------- 1 root root 4096 Sep 8 19:58 uevent
>>
>> With 2.6.23-rc5:
>>
>> > # ls -l /sys/class/input/input5
>> > total 0
>> > drwxr-xr-x 2 root root 0 Sep 8 19:47 capabilities/
>> > lrwxrwxrwx 1 root root 0 Sep 8 19:03 device ->
>> > ../../../devices/platform/pcspkr/
>> > drwxr-xr-x 2 root root 0 Sep 8 19:47 id/
>> > lrwxrwxrwx 1 root root 0 Sep 8 19:47 input:event5 ->
>> > ../../../class/input/event5/
>> > -r--r--r-- 1 root root 4096 Sep 8 19:03 modalias
>> > -r--r--r-- 1 root root 4096 Sep 8 19:03 name
>> > -r--r--r-- 1 root root 4096 Sep 8 19:47 phys
>> > drwxr-xr-x 2 root root 0 Sep 8 19:47 power/
>> > lrwxrwxrwx 1 root root 0 Sep 8 19:03 subsystem ->
>> > ../../../class/input/
>> > -rw-r--r-- 1 root root 4096 Sep 8 19:03 uevent
>> > -r--r--r-- 1 root root 4096 Sep 8 19:47 uniq
>>
>> > # ls -l /sys/class/input/event5
>> > total 0
>> > -r--r--r-- 1 root root 4096 Sep 8 19:03 dev
>> > lrwxrwxrwx 1 root root 0 Sep 8 19:03 device ->
>> > ../../../class/input/input5/
>> > drwxr-xr-x 2 root root 0 Sep 8 19:48 power/
>> > lrwxrwxrwx 1 root root 0 Sep 8 19:03 subsystem ->
>> > ../../../class/input/
>> > -rw-r--r-- 1 root root 4096 Sep 8 19:03 uevent
>>
>> There are a few changes.
>>
>> There is no longer:
>> /sys/class/input/eventX => /sys/class/input/inputX/eventX
>> instead there is:
>> /sys/class/inputX/input:eventX => /sys/class/input/eventX
>> Notice the added "input:". I don't know if any software depends on this,
>> though.
>>
>> However, the change that broke id_path of udev is that
>> /sys/class/input/event5/device is now a symlink to the inputX directory
>> instead of being the same as the device symlink in inputX directory,
>> i.e. to ../../../devices/platform/pcspkr in this case.
>>
>> Udev id_path uses that directory to construct the ID_PATH variable.
>> Should the sysfs structure be reverted or should udev be adapted to
>> handle traversing /device symlink twice? I think the former, as there
>> should be considerably more time to adapt udev for coming changes in
>> sysfs.
>
> Udev's path_id script is too dumb to follow the "device" link of
> stacked class devices in the CONFIG_SYSFS_DEPRECATED=y layout. Does
> this change fix it for you?
>
http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff_plain;h=b1ac36ff5e3756cefc79967a26280056da31bf6f
>
This just delays the issue until we have 3 levels of indirection :)
next prev parent reply other threads:[~2007-09-10 2:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-08 17:08 Anssi Hannula
2007-09-08 18:29 ` Andrey Borzenkov
2007-09-08 19:38 ` Anssi Hannula
2007-09-08 19:46 ` Andrey Borzenkov
2007-09-09 23:03 ` Kay Sievers
2007-09-10 2:40 ` Andrey Borzenkov [this message]
2007-09-10 5:28 ` Dmitry Torokhov
2007-09-10 5:44 ` Greg KH
2007-09-10 13:24 ` Dmitry Torokhov
2007-09-15 8:05 ` Andrew Morton
2007-09-15 14:18 ` Dmitry Torokhov
2007-09-15 15:46 ` Anssi Hannula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070910024057.D7D91411ABE@smtp03.mtu.ru \
--to=arvidjaar@mail.ru \
--cc=anssi.hannula@gmail.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®