mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: greg@kroah.com
Cc: andre@finow14.de, torvalds@osdl.org, marcel@holtmann.org,
	linux-kernel@vger.kernel.org
Subject: Re: hci_sock.c build failure
Date: Wed, 12 Sep 2007 05:12:12 -0700 (PDT)	[thread overview]
Message-ID: <20070912.051212.112608750.davem@davemloft.net> (raw)
In-Reply-To: <20070912120253.GA13003@kroah.com>

From: Greg KH <greg@kroah.com>
Date: Wed, 12 Sep 2007 05:02:53 -0700

> It's not even a randconfig issue, my build dies too (this is Linus's
> current tree.)
> 
> Time to poke through the 10 bluetooth patches that were just added...

I'll push the following fix to Linus.

>From 1da97f83a843f92678b614fcaebdb3e4ebd6c9dd Mon Sep 17 00:00:00 2001
From: David S. Miller <davem@kimchee.(none)>
Date: Wed, 12 Sep 2007 14:10:58 +0200
Subject: [PATCH] [BLUETOOTH]: Fix non-COMPAT build of hci_sock.c

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 net/bluetooth/hci_sock.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c
index d16ca8e..5ccea5f 100644
--- a/net/bluetooth/hci_sock.c
+++ b/net/bluetooth/hci_sock.c
@@ -348,16 +348,17 @@ static inline void hci_sock_cmsg(struct sock *sk, struct msghdr *msg, struct sk_
 
 		skb_get_timestamp(skb, &tv);
 
+		data = &tv;
+		len = sizeof(tv);
+#ifdef CONFIG_COMPAT
 		if (msg->msg_flags & MSG_CMSG_COMPAT) {
 			struct compat_timeval ctv;
 			ctv.tv_sec = tv.tv_sec;
 			ctv.tv_usec = tv.tv_usec;
 			data = &ctv;
 			len = sizeof(ctv);
-		} else {
-			data = &tv;
-			len = sizeof(tv);
 		}
+#endif
 
 		put_cmsg(msg, SOL_HCI, HCI_CMSG_TSTAMP, len, data);
 	}
-- 
1.5.2.4


  parent reply	other threads:[~2007-09-12 12:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-12  9:29 Andre Haupt
2007-09-12 12:02 ` Greg KH
2007-09-12 12:04   ` Greg KH
2007-09-12 12:07     ` Greg KH
2007-09-12 12:10       ` S.Çağlar Onur
2007-09-12 12:14       ` David Miller
2007-09-12 12:13     ` David Miller
2007-09-12 12:12   ` David Miller [this message]
2007-09-12 14:20     ` Coly Li
2007-09-12 14:26       ` Coly Li
2007-09-12 16:20     ` Marcel Holtmann
2007-09-12 12:16   ` Robert P. J. Day
2007-09-13 10:11 Toralf Förster
2007-09-13 12:29 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070912.051212.112608750.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andre@finow14.de \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®