mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Toralf Förster" <toralf.foerster@gmx.de>
To: davem@davemloft.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: hci_sock.c build failure
Date: Thu, 13 Sep 2007 12:11:09 +0200	[thread overview]
Message-ID: <200709131211.10950.toralf.foerster@gmx.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

Hello,

I'm wondering why the build failure wasn't fixed by a patch like this:


diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c
index 5ccea5f..85416bb 100644
--- a/net/bluetooth/hci_sock.c
+++ b/net/bluetooth/hci_sock.c
@@ -348,8 +348,6 @@ static inline void hci_sock_cmsg(struct sock *sk, struct msghdr *msg, struct sk_

                skb_get_timestamp(skb, &tv);

-               data = &tv;
-               len = sizeof(tv);
 #ifdef CONFIG_COMPAT
                if (msg->msg_flags & MSG_CMSG_COMPAT) {
                        struct compat_timeval ctv;
@@ -358,6 +356,9 @@ static inline void hci_sock_cmsg(struct sock *sk, struct msghdr *msg, struct sk_
                        data = &ctv;
                        len = sizeof(ctv);
                }
+#else
+               data = &tv;
+               len = sizeof(tv);
 #endif

                put_cmsg(msg, SOL_HCI, HCI_CMSG_TSTAMP, len, data);


-- 
MfG/Sincerely

Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

             reply	other threads:[~2007-09-13 10:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-13 10:11 Toralf Förster [this message]
2007-09-13 12:29 ` Marcel Holtmann
  -- strict thread matches above, loose matches on Subject: below --
2007-09-12  9:29 Andre Haupt
2007-09-12 12:02 ` Greg KH
2007-09-12 12:04   ` Greg KH
2007-09-12 12:07     ` Greg KH
2007-09-12 12:10       ` S.Çağlar Onur
2007-09-12 12:14       ` David Miller
2007-09-12 12:13     ` David Miller
2007-09-12 12:12   ` David Miller
2007-09-12 14:20     ` Coly Li
2007-09-12 14:26       ` Coly Li
2007-09-12 16:20     ` Marcel Holtmann
2007-09-12 12:16   ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200709131211.10950.toralf.foerster@gmx.de \
    --to=toralf.foerster@gmx.de \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®