mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Nick Piggin <npiggin@suse.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andi Kleen <ak@suse.de>
Subject: Re: [patch] x86: improved memory barrier implementation
Date: Fri, 28 Sep 2007 18:18:31 +0100	[thread overview]
Message-ID: <20070928181831.26f34a64@the-village.bc.nu> (raw)
In-Reply-To: <20070928165425.GA7366@wotan.suse.de>

> on the broken ppro stores config option if you just tell me what should
> be there (again, remember that my patch isn't actually changing anything
> already there except for smp_rmb side).

The PPro needs rmb to ensure a store doesn't go for a walk on the wild
side and pass the read especially when we are dealing with device space.
The rest of the stuff is a little vague which makes me nervous when
considering relaxing the PPro case for smp_rmb. With smp_rmb as it is at
the moment the PPro is effectively treated as an out of order cpu and so
shouldn't hit anything occassionally that a PPC wouldn't hit every time.

> > - and for modern processors its still not remotely clear your patch is
> > correct because of NT stores.
> 
> No. We already _have_ to rely on this model for barriers 

Well Linus has dealt with the question of NT stores for us now...

Given this isn't an issue on 64bit I'm inclined to argue that only 64bit
behaviour should be changed at this point.

Alan

  reply	other threads:[~2007-09-28 17:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-28 15:48 Nick Piggin
2007-09-28 16:07 ` Alan Cox
2007-09-28 16:15   ` Linus Torvalds
2007-09-29 13:17     ` Nick Piggin
2007-09-29 16:07       ` Linus Torvalds
2007-09-30 12:16         ` Nick Piggin
2007-09-28 16:54   ` Nick Piggin
2007-09-28 17:18     ` Alan Cox [this message]
2007-09-29 13:19       ` Nick Piggin
2007-09-30  1:43   ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070928181831.26f34a64@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@suse.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®