From: Pavel Machek <pavel@ucw.cz>
To: Andrew Morton <akpm@osdl.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: CodingStyle: mention bitfields/whitespace style, prefer (!foo) in examples
Date: Thu, 4 Oct 2007 11:44:22 +0200 [thread overview]
Message-ID: <20071004094422.GA652@elf.ucw.cz> (raw)
Mention whitespace and bitfields style, prefer (!foo) to (foo == NULL)
in examples.
Signed-off-by: Pavel Machek <pavel@suse.cz>
diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
index 7f1730f..1595a45 100644
--- a/Documentation/CodingStyle
+++ b/Documentation/CodingStyle
@@ -71,6 +71,15 @@ used for indentation, and the above exam
Get a decent editor and don't leave whitespace at the end of lines.
+Bitfield variables should be indented like this:
+
+ unsigned int foo :1;
+
+Do not put whitespace between any of the unary operators and their operand.
+
+It is usually unnecessary to have whitespace around parentheses as
+part of expressions, around brackets, or around the operators . and
+->.
Chapter 2: Breaking long lines and strings
@@ -403,7 +412,7 @@ int fun(int a)
int result = 0;
char *buffer = kmalloc(SIZE);
- if (buffer == NULL)
+ if (!buffer)
return -ENOMEM;
if (condition1) {
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next reply other threads:[~2007-10-04 9:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 9:44 Pavel Machek [this message]
2007-10-04 9:51 ` Jan Engelhardt
2007-10-04 10:19 ` Pavel Machek
2007-10-06 12:40 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004094422.GA652@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®