From: Pavel Machek <pavel@ucw.cz>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Andrew Morton <akpm@osdl.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: CodingStyle: mention bitfields/whitespace style, prefer (!foo) in examples
Date: Thu, 4 Oct 2007 12:19:01 +0200 [thread overview]
Message-ID: <20071004101901.GK22940@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.64.0710041151120.7253@fbirervta.pbzchgretzou.qr>
On Thu 2007-10-04 11:51:35, Jan Engelhardt wrote:
>
> On Oct 4 2007 11:44, Pavel Machek wrote:
> >diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
> >index 7f1730f..1595a45 100644
> >--- a/Documentation/CodingStyle
> >+++ b/Documentation/CodingStyle
> >@@ -71,6 +71,15 @@ used for indentation, and the above exam
> >
> > Get a decent editor and don't leave whitespace at the end of lines.
> >
> >+Bitfield variables should be indented like this:
> >+
> >+ unsigned int foo :1;
>
> Current code uses foo:1.
I'm fine with foo :1 or foo:1. It just would be nice to have example
specifying one way...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-10-04 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 9:44 Pavel Machek
2007-10-04 9:51 ` Jan Engelhardt
2007-10-04 10:19 ` Pavel Machek [this message]
2007-10-06 12:40 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004101901.GK22940@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®