From: Gregory Haskins <ghaskins@novell.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>
Cc: linux-rt-users <linux-rt-users@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Gregory Haskins <ghaskins@novell.com>
Subject: [PATCH 2/7] RT: Peter Zijlstra's suggested improvements to rt-push patch
Date: Thu, 11 Oct 2007 17:59:53 -0400 [thread overview]
Message-ID: <20071011215953.27097.46608.stgit@novell1.haskins.net> (raw)
In-Reply-To: <20071011213916.27097.42597.stgit@novell1.haskins.net>
This is my own interpretation of Peter's recommended changes Steven's push-rt
patch. Just to be clear, Peter does not endorse this patch unless he himself
specifically says so ;).
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
kernel/sched.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 0f0af6d..24b38b4 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -1499,7 +1499,7 @@ static int push_rt_task(struct rq *this_rq)
int dst_cpu = -1;
int ret = 0;
- BUG_ON(!spin_is_locked(&this_rq->lock));
+ assert_spin_locked(&this_rq->lock);
next_task = rt_next_highest_task(this_rq);
if (!next_task)
@@ -1553,7 +1553,8 @@ static int push_rt_task(struct rq *this_rq)
set_task_cpu(next_task, dst_cpu);
activate_task(lowest_rq, next_task, 0);
- set_tsk_need_resched(lowest_rq->curr);
+ resched_task(lowest_rq->curr);
+ schedstat_inc(this_rq, rto_schedule);
spin_unlock(&lowest_rq->lock);
ret = 1;
@@ -2290,10 +2291,9 @@ static inline void finish_task_switch(struct rq *rq, struct task_struct *prev)
* then kick other CPUs, they might run it:
*/
rq->curr_prio = current->prio;
- if (unlikely(rt_task(current) && push_rt_task(rq))) {
- schedstat_inc(rq, rto_schedule);
- smp_send_reschedule_allbutself_cpumask(current->cpus_allowed);
- }
+ if (unlikely(rq->rt_nr_running > 1))
+ push_rt_task(rq);
+
#endif
prev_state = prev->state;
_finish_arch_switch(prev);
next prev parent reply other threads:[~2007-10-11 22:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 21:59 [PATCH 0/7] RT: (RFC) RT-Overload/Sched enhancements Gregory Haskins
2007-10-11 21:59 ` [PATCH 1/7] RT: Push waiting rt tasks Gregory Haskins
2007-10-11 21:59 ` Gregory Haskins [this message]
2007-10-11 21:59 ` [PATCH 3/7] RT: Only consider online CPUs when pushing " Gregory Haskins
2007-10-12 12:10 ` Steven Rostedt
2007-10-11 22:00 ` [PATCH 4/7] RT: Add a per-cpu rt_overload indication Gregory Haskins
2007-10-11 22:00 ` [PATCH 5/7] RT: CPU priority management Gregory Haskins
2007-10-11 22:00 ` [PATCH 6/7] RT: Convert Steve's rt-push infrastructure to cpupri Gregory Haskins
2007-10-11 22:00 ` [PATCH 7/7] RT: push-rt enhancements Gregory Haskins
2007-10-12 10:29 ` [PATCH 0/7] RT: (RFC) RT-Overload/Sched enhancements Peter Zijlstra
2007-10-12 11:47 ` Steven Rostedt
2007-10-12 13:20 ` Gregory Haskins
2007-10-12 14:05 ` Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071011215953.27097.46608.stgit@novell1.haskins.net \
--to=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®