From: Gregory Haskins <ghaskins@novell.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>
Cc: linux-rt-users <linux-rt-users@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Gregory Haskins <ghaskins@novell.com>
Subject: [PATCH 4/7] RT: Add a per-cpu rt_overload indication
Date: Thu, 11 Oct 2007 18:00:04 -0400 [thread overview]
Message-ID: <20071011220004.27097.98345.stgit@novell1.haskins.net> (raw)
In-Reply-To: <20071011213916.27097.42597.stgit@novell1.haskins.net>
The system currently evaluates all online CPUs whenever one or more enters
an rt_overload condition. This suffers from scalability limitations as
the # of online CPUs increases. So we introduce a cpumask to track
exactly which CPUs need RT balancing.
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
CC: Peter W. Morreale <pmorreale@novell.com>
---
kernel/sched.c | 12 +++++++++---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 0ca3905..41b0e9c 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -632,6 +632,7 @@ static inline struct rq *this_rq_lock(void)
#if defined(CONFIG_PREEMPT_RT) && defined(CONFIG_SMP)
static __cacheline_aligned_in_smp atomic_t rt_overload;
+static cpumask_t rto_cpus;
#endif
static inline void inc_rt_tasks(struct task_struct *p, struct rq *rq)
@@ -640,8 +641,11 @@ static inline void inc_rt_tasks(struct task_struct *p, struct rq *rq)
if (rt_task(p)) {
rq->rt_nr_running++;
# ifdef CONFIG_SMP
- if (rq->rt_nr_running == 2)
+ if (rq->rt_nr_running == 2) {
+ cpu_set(rq->cpu, rto_cpus);
+ smp_wmb();
atomic_inc(&rt_overload);
+ }
# endif
}
#endif
@@ -654,8 +658,10 @@ static inline void dec_rt_tasks(struct task_struct *p, struct rq *rq)
WARN_ON(!rq->rt_nr_running);
rq->rt_nr_running--;
# ifdef CONFIG_SMP
- if (rq->rt_nr_running == 1)
+ if (rq->rt_nr_running == 1) {
atomic_dec(&rt_overload);
+ cpu_clear(rq->cpu, rto_cpus);
+ }
# endif
}
#endif
@@ -1590,7 +1596,7 @@ static void balance_rt_tasks(struct rq *this_rq, int this_cpu)
*/
next = pick_next_task(this_rq, this_rq->curr);
- for_each_online_cpu(cpu) {
+ for_each_cpu_mask(cpu, rto_cpus) {
if (cpu == this_cpu)
continue;
src_rq = cpu_rq(cpu);
next prev parent reply other threads:[~2007-10-11 22:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 21:59 [PATCH 0/7] RT: (RFC) RT-Overload/Sched enhancements Gregory Haskins
2007-10-11 21:59 ` [PATCH 1/7] RT: Push waiting rt tasks Gregory Haskins
2007-10-11 21:59 ` [PATCH 2/7] RT: Peter Zijlstra's suggested improvements to rt-push patch Gregory Haskins
2007-10-11 21:59 ` [PATCH 3/7] RT: Only consider online CPUs when pushing rt tasks Gregory Haskins
2007-10-12 12:10 ` Steven Rostedt
2007-10-11 22:00 ` Gregory Haskins [this message]
2007-10-11 22:00 ` [PATCH 5/7] RT: CPU priority management Gregory Haskins
2007-10-11 22:00 ` [PATCH 6/7] RT: Convert Steve's rt-push infrastructure to cpupri Gregory Haskins
2007-10-11 22:00 ` [PATCH 7/7] RT: push-rt enhancements Gregory Haskins
2007-10-12 10:29 ` [PATCH 0/7] RT: (RFC) RT-Overload/Sched enhancements Peter Zijlstra
2007-10-12 11:47 ` Steven Rostedt
2007-10-12 13:20 ` Gregory Haskins
2007-10-12 14:05 ` Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071011220004.27097.98345.stgit@novell1.haskins.net \
--to=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®