* [2.6.24 PATCH 03/25] dm crypt: drop device ref in ctr error path
@ 2007-10-12 17:05 Alasdair G Kergon
0 siblings, 0 replies; only message in thread
From: Alasdair G Kergon @ 2007-10-12 17:05 UTC (permalink / raw)
To: Linus Torvalds; +Cc: dm-devel, linux-kernel, Dmitry Monakhov, Milan Broz
From: Dmitry Monakhov <dmonakhov@openvz.org>
Add a missing 'dm_put_device' in an error path in crypt target constructor.
Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
Signed-off-by: Milan Broz <mbroz@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
---
drivers/md/dm-crypt.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)
Index: linux-2.6.23/drivers/md/dm-crypt.c
===================================================================
--- linux-2.6.23.orig/drivers/md/dm-crypt.c 2007-10-12 13:15:20.000000000 +0100
+++ linux-2.6.23/drivers/md/dm-crypt.c 2007-10-12 13:15:30.000000000 +0100
@@ -882,7 +882,7 @@ static int crypt_ctr(struct dm_target *t
cc->iv_mode = kmalloc(strlen(ivmode) + 1, GFP_KERNEL);
if (!cc->iv_mode) {
ti->error = "Error kmallocing iv_mode string";
- goto bad5;
+ goto bad_iv_mode;
}
strcpy(cc->iv_mode, ivmode);
} else
@@ -891,6 +891,8 @@ static int crypt_ctr(struct dm_target *t
ti->private = cc;
return 0;
+bad_iv_mode:
+ dm_put_device(ti, cc->dev);
bad5:
bioset_free(cc->bs);
bad_bs:
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-10-12 17:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-12 17:05 [2.6.24 PATCH 03/25] dm crypt: drop device ref in ctr error path Alasdair G Kergon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®