From: Samuel Ortiz <samuel@sortiz.org>
To: "hinko.kocevar@cetrtapot.si" <hinko.kocevar@cetrtapot.si>
Cc: irda-users@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [irda-users] [PATCH] mcs7780 needs to free allocated rx buffer
Date: Sat, 13 Oct 2007 03:59:59 +0300 [thread overview]
Message-ID: <20071013005959.GB8187@sortiz.org> (raw)
In-Reply-To: <470F6A5E.9050703@cetrtapot.si>
Hi Hinko,
On Fri, Oct 12, 2007 at 02:36:46PM +0200, hinko.kocevar@cetrtapot.si wrote:
> Hi,
>
> While testing the mcs7780 based IrDA USB dongle I've stumbled upon
> memory leak in mcs_net_close(). Patch below fixes it.
Thanks for the fix. Applied to my local git, will push forward.
Cheers,
Samuel.
> Signed-off-by: Hinko Kocevar <hinko.kocevar@cetrtapot.si>
>
> Best regards,
> Hinko
>
> ----
>
>
> --- linux-2.6.23/drivers/net/irda/mcs7780.c.orig 2007-10-12 14:02:55.000000000 +0200
> +++ linux-2.6.23/drivers/net/irda/mcs7780.c 2007-10-12 14:05:03.000000000 +0200
> @@ -678,6 +678,8 @@ static int mcs_net_close(struct net_devi
> /* Stop transmit processing */
> netif_stop_queue(netdev);
>
> + kfree_skb(mcs->rx_buff.skb);
> +
> /* kill and free the receive and transmit URBs */
> usb_kill_urb(mcs->rx_urb);
> usb_free_urb(mcs->rx_urb);
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems? Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> _______________________________________________
> irda-users mailing list
> irda-users@lists.sourceforge.net
> http://lists.sourceforge.net/lists/listinfo/irda-users
prev parent reply other threads:[~2007-10-13 1:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 12:36 hinko.kocevar
2007-10-13 0:59 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071013005959.GB8187@sortiz.org \
--to=samuel@sortiz.org \
--cc=hinko.kocevar@cetrtapot.si \
--cc=irda-users@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®