From: "hinko.kocevar@cetrtapot.si" <hinko.kocevar@cetrtapot.si>
To: irda-users@lists.sourceforge.net
Cc: Samuel Ortiz <samuel@sortiz.org>, linux-kernel@vger.kernel.org
Subject: [PATCH] mcs7780 needs to free allocated rx buffer
Date: Fri, 12 Oct 2007 14:36:46 +0200 [thread overview]
Message-ID: <470F6A5E.9050703@cetrtapot.si> (raw)
[-- Attachment #1: Type: text/plain, Size: 214 bytes --]
Hi,
While testing the mcs7780 based IrDA USB dongle I've stumbled upon
memory leak in mcs_net_close(). Patch below fixes it.
Signed-off-by: Hinko Kocevar <hinko.kocevar@cetrtapot.si>
Best regards,
Hinko
----
[-- Attachment #2: mcs7780-free-rx_buff.diff --]
[-- Type: text/plain, Size: 432 bytes --]
--- linux-2.6.23/drivers/net/irda/mcs7780.c.orig 2007-10-12 14:02:55.000000000 +0200
+++ linux-2.6.23/drivers/net/irda/mcs7780.c 2007-10-12 14:05:03.000000000 +0200
@@ -678,6 +678,8 @@ static int mcs_net_close(struct net_devi
/* Stop transmit processing */
netif_stop_queue(netdev);
+ kfree_skb(mcs->rx_buff.skb);
+
/* kill and free the receive and transmit URBs */
usb_kill_urb(mcs->rx_urb);
usb_free_urb(mcs->rx_urb);
next reply other threads:[~2007-10-12 13:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 12:36 hinko.kocevar [this message]
2007-10-13 0:59 ` [irda-users] " Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470F6A5E.9050703@cetrtapot.si \
--to=hinko.kocevar@cetrtapot.si \
--cc=irda-users@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®