mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Avi Kivity <avi@qumranet.com>
Subject: Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.
Date: Mon, 15 Oct 2007 11:38:00 +0200	[thread overview]
Message-ID: <20071015093800.GA22818@elte.hu> (raw)
In-Reply-To: <46E550EF.5080209@bull.net>


* Laurent Vivier <Laurent.Vivier@bull.net> wrote:

> [PATCH 4/4] Modify KVM to update guest time accounting.

FYI, KVM abstracted its guest-mode entry code recently so this did not 
apply - find below the reworked patch.

	Ingo

------------------->
Subject: sched: guest CPU accounting: maintain guest state in KVM
From: Laurent Vivier <Laurent.Vivier@bull.net>

Modify KVM to update guest time accounting.

[ mingo@elte.hu: ported to 2.6.24 KVM. ]

Signed-off-by: Laurent Vivier <Laurent.Vivier@bull.net>
Acked-by: Avi Kivity <avi@qumranet.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/kvm/kvm.h      |   16 ++++++++++++++++
 drivers/kvm/kvm_main.c |    2 ++
 2 files changed, 18 insertions(+)

Index: linux/drivers/kvm/kvm.h
===================================================================
--- linux.orig/drivers/kvm/kvm.h
+++ linux/drivers/kvm/kvm.h
@@ -624,6 +624,22 @@ void kvm_mmu_unload(struct kvm_vcpu *vcp
 
 int kvm_hypercall(struct kvm_vcpu *vcpu, struct kvm_run *run);
 
+/*
+ * Compatibility define - PF_VCPU is only available in v2.6.24+ kernels:
+ */
+#ifndef PF_VCPU
+# define PF_VCPU	0
+#endif
+
+static inline void kvm_guest_enter(void)
+{
+	current->flags |= PF_VCPU;
+}
+
+static inline void kvm_guest_exit(void)
+{
+}
+
 static inline int kvm_mmu_page_fault(struct kvm_vcpu *vcpu, gva_t gva,
 				     u32 error_code)
 {
Index: linux/drivers/kvm/kvm_main.c
===================================================================
--- linux.orig/drivers/kvm/kvm_main.c
+++ linux/drivers/kvm/kvm_main.c
@@ -2046,6 +2046,7 @@ again:
 		kvm_x86_ops->inject_pending_vectors(vcpu, kvm_run);
 
 	vcpu->guest_mode = 1;
+	kvm_guest_enter();
 
 	if (vcpu->requests)
 		if (test_and_clear_bit(KVM_TLB_FLUSH, &vcpu->requests))
@@ -2053,6 +2054,7 @@ again:
 
 	kvm_x86_ops->run(vcpu, kvm_run);
 
+	kvm_guest_exit();
 	vcpu->guest_mode = 0;
 	local_irq_enable();
 

  reply	other threads:[~2007-10-15  9:38 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-10 14:13 Laurent Vivier
2007-10-15  9:38 ` Ingo Molnar [this message]
2007-10-15  9:47   ` Avi Kivity
2007-10-15  9:50     ` Ingo Molnar
2007-10-15  9:51     ` Ingo Molnar
2007-10-15 10:02       ` Avi Kivity
2007-10-15 10:53         ` Laurent Vivier
2007-10-15 11:15           ` Avi Kivity
2007-10-15 11:33             ` Christian Borntraeger
2007-10-15 11:38               ` Laurent Vivier
2007-10-15 14:39                 ` Christian Borntraeger
2007-10-15 14:45                   ` Laurent Vivier
2007-10-15 11:37             ` Laurent Vivier
2007-10-15 12:07               ` Avi Kivity
2007-10-15 12:29                 ` Laurent Vivier
2007-10-15 16:46                   ` Avi Kivity
2007-10-15 19:45                     ` Laurent Vivier
2007-10-17 13:08                   ` [PATCH] clear PF_VCPU in kvm_guest_exit() Laurent Vivier
2007-10-17 13:18                     ` Christian Borntraeger
2007-10-17 14:16                     ` Avi Kivity
2007-10-17 15:09                       ` Laurent Vivier
2007-10-18 12:39                     ` Use virtual cpu accounting if available for guest times Christian Borntraeger
2007-10-18 12:41                       ` Avi Kivity
2007-10-19 16:57                       ` [kvm-devel] " Hollis Blanchard
2007-10-19 17:18                         ` Hollis Blanchard
2007-10-18 13:19                   ` [PATCH] move kvm_guest_exit() after local_irq_enable() Laurent Vivier
2007-10-18 13:32                     ` [kvm-devel] " Avi Kivity
2007-10-18 13:49                       ` Laurent Vivier
2007-10-22  8:26                     ` Ingo Molnar
2007-10-22  8:51                       ` Avi Kivity
2007-10-22  8:57                         ` Ingo Molnar
2007-10-22  9:10                           ` [kvm-devel] " Avi Kivity
2007-10-15 11:19           ` [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071015093800.GA22818@elte.hu \
    --to=mingo@elte.hu \
    --cc=Laurent.Vivier@bull.net \
    --cc=avi@qumranet.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®