From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Avi Kivity <avi@qumranet.com>
Cc: Laurent Vivier <Laurent.Vivier@bull.net>,
linux-kernel@vger.kernel.org,
kvm-devel <kvm-devel@lists.sourceforge.net>
Subject: Use virtual cpu accounting if available for guest times.
Date: Thu, 18 Oct 2007 14:39:10 +0200 [thread overview]
Message-ID: <200710181439.10390.borntraeger@de.ibm.com> (raw)
In-Reply-To: <11926264852739-git-send-email-Laurent.Vivier@bull.net>
Avi,
ppc and s390 offer the possibility to track process times precisely
by looking at cpu timer on every context switch, irq, softirq etc.
We can use that infrastructure as well for guest time accounting.
We need to account the used time before we change the state.
This patch adds a call to account_system_vtime to kvm_guest_enter
and kvm_guest exit. If CONFIG_VIRT_CPU_ACCOUNTING is not set,
account_system_vtime is defined in hardirq.h as an empty function,
which means this patch does not change the behaviour on other
platforms.
I compile tested this patch on x86 and function tested the patch on
s390.
Avi, please apply.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
drivers/kvm/kvm.h | 3 +++
1 file changed, 3 insertions(+)
Index: kvm/drivers/kvm/kvm.h
===================================================================
--- kvm.orig/drivers/kvm/kvm.h
+++ kvm/drivers/kvm/kvm.h
@@ -7,6 +7,7 @@
*/
#include <linux/types.h>
+#include <linux/hardirq.h>
#include <linux/list.h>
#include <linux/mutex.h>
#include <linux/spinlock.h>
@@ -669,11 +670,13 @@ __init void kvm_arch_init(void);
static inline void kvm_guest_enter(void)
{
+ account_system_vtime(current);
current->flags |= PF_VCPU;
}
static inline void kvm_guest_exit(void)
{
+ account_system_vtime(current);
current->flags &= ~PF_VCPU;
}
next prev parent reply other threads:[~2007-10-18 12:39 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-10 14:13 [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting Laurent Vivier
2007-10-15 9:38 ` Ingo Molnar
2007-10-15 9:47 ` Avi Kivity
2007-10-15 9:50 ` Ingo Molnar
2007-10-15 9:51 ` Ingo Molnar
2007-10-15 10:02 ` Avi Kivity
2007-10-15 10:53 ` Laurent Vivier
2007-10-15 11:15 ` Avi Kivity
2007-10-15 11:33 ` Christian Borntraeger
2007-10-15 11:38 ` Laurent Vivier
2007-10-15 14:39 ` Christian Borntraeger
2007-10-15 14:45 ` Laurent Vivier
2007-10-15 11:37 ` Laurent Vivier
2007-10-15 12:07 ` Avi Kivity
2007-10-15 12:29 ` Laurent Vivier
2007-10-15 16:46 ` Avi Kivity
2007-10-15 19:45 ` Laurent Vivier
2007-10-17 13:08 ` [PATCH] clear PF_VCPU in kvm_guest_exit() Laurent Vivier
2007-10-17 13:18 ` Christian Borntraeger
2007-10-17 14:16 ` Avi Kivity
2007-10-17 15:09 ` Laurent Vivier
2007-10-18 12:39 ` Christian Borntraeger [this message]
2007-10-18 12:41 ` Use virtual cpu accounting if available for guest times Avi Kivity
2007-10-19 16:57 ` [kvm-devel] " Hollis Blanchard
2007-10-19 17:18 ` Hollis Blanchard
2007-10-18 13:19 ` [PATCH] move kvm_guest_exit() after local_irq_enable() Laurent Vivier
2007-10-18 13:32 ` [kvm-devel] " Avi Kivity
2007-10-18 13:49 ` Laurent Vivier
2007-10-22 8:26 ` Ingo Molnar
2007-10-22 8:51 ` Avi Kivity
2007-10-22 8:57 ` Ingo Molnar
2007-10-22 9:10 ` [kvm-devel] " Avi Kivity
2007-10-15 11:19 ` [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710181439.10390.borntraeger@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=Laurent.Vivier@bull.net \
--cc=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®