From: Herbert Xu <herbert@gondor.apana.org.au>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: benh@kernel.crashing.org,
Linus Torvalds <torvalds@linux-foundation.org>,
akpm <akpm@linux-foundation.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] synchronize_irq needs a barrier
Date: Sat, 20 Oct 2007 11:37:52 +0800 [thread overview]
Message-ID: <20071020033752.GA20760@gondor.apana.org.au> (raw)
In-Reply-To: <200710200402.43106.maximlevitsky@gmail.com>
On Sat, Oct 20, 2007 at 02:02:42AM +0000, Maxim Levitsky wrote:
>
> Thus I now understand that .suspend() should do:
>
> saa_writel(SAA7134_IRQ1, 0);
> saa_writel(SAA7134_IRQ2, 0);
> saa_writel(SAA7134_MAIN_CTRL, 0);
>
> dev->insuspend = 1;
> smp_wmb();
If we patch synchronize_irq() as discussed here then you can
use it in place of smp_wmb() and remove the smp_rmb from the
interrupt handler (the latter is the path that matters).
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2007-10-20 3:38 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 1:25 Benjamin Herrenschmidt
2007-10-18 1:45 ` Andrew Morton
2007-10-18 1:55 ` Benjamin Herrenschmidt
2007-10-18 2:12 ` Linus Torvalds
2007-10-18 2:40 ` Benjamin Herrenschmidt
2007-10-18 2:57 ` Benjamin Herrenschmidt
2007-10-18 14:56 ` Herbert Xu
2007-10-18 22:05 ` Benjamin Herrenschmidt
2007-10-18 22:52 ` Linus Torvalds
2007-10-18 23:17 ` Benjamin Herrenschmidt
2007-10-18 23:39 ` Linus Torvalds
2007-10-18 23:52 ` Benjamin Herrenschmidt
2007-10-19 2:32 ` Herbert Xu
2007-10-19 2:52 ` Nick Piggin
2007-10-19 3:28 ` Herbert Xu
2007-10-19 4:49 ` Nick Piggin
2007-10-19 2:55 ` Linus Torvalds
2007-10-19 3:26 ` Linus Torvalds
2007-10-19 4:11 ` Benjamin Herrenschmidt
2007-10-19 4:26 ` Benjamin Herrenschmidt
2007-10-19 5:53 ` Herbert Xu
2007-10-19 4:20 ` Herbert Xu
2007-10-19 4:29 ` Benjamin Herrenschmidt
2007-10-19 4:35 ` Benjamin Herrenschmidt
2007-10-19 4:48 ` Herbert Xu
2007-10-19 4:58 ` Benjamin Herrenschmidt
2007-10-21 21:10 ` Benjamin Herrenschmidt
2007-10-23 3:26 ` [IRQ]: Fix synchronize_irq races with IRQ handler Herbert Xu
2007-10-19 5:36 ` [NET]: Fix possible dev_deactivate race condition Herbert Xu
2007-10-19 5:38 ` David Miller
2007-10-19 7:35 ` Peter Zijlstra
2007-10-19 9:29 ` Herbert Xu
2007-10-18 14:35 ` [PATCH] synchronize_irq needs a barrier Herbert Xu
2007-10-18 21:35 ` Benjamin Herrenschmidt
2007-10-20 2:02 ` Maxim Levitsky
2007-10-20 2:25 ` Linus Torvalds
2007-10-20 3:10 ` Maxim Levitsky
2007-10-20 4:06 ` Benjamin Herrenschmidt
2007-10-20 4:04 ` Benjamin Herrenschmidt
2007-10-20 4:09 ` Benjamin Herrenschmidt
2007-10-20 3:37 ` Herbert Xu [this message]
2007-10-20 3:56 ` Benjamin Herrenschmidt
2007-10-20 4:24 ` Maxim Levitsky
2007-10-20 5:04 ` Benjamin Herrenschmidt
2007-10-20 5:36 ` Maxim Levitsky
2007-10-20 5:46 ` Benjamin Herrenschmidt
2007-10-20 6:06 ` Maxim Levitsky
2007-10-20 6:13 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071020033752.GA20760@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=maximlevitsky@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®