From: Herbert Xu <herbert@gondor.apana.org.au>
To: Rik van Riel <riel@redhat.com>
Cc: Roel Kluin <12o3l@tiscali.nl>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] return hidden bug
Date: Mon, 22 Oct 2007 13:02:44 +0800 [thread overview]
Message-ID: <20071022050243.GA16384@gondor.apana.org.au> (raw)
In-Reply-To: <20071021214209.1a7567d7@bree.surriel.com>
On Mon, Oct 22, 2007 at 01:42:09AM +0000, Rik van Riel wrote:
>
> BUG() will terminate the process that runs into it, so you can
> just remove the return alltogether. If BUG() is hit, the return
> will never be reached.
This is true in general. However, if someone builds the kernel
with CONFIG_BUG disabled then the return statement will make a
difference. Of course, if you're brave enough to have CONFIG_BUG
off then you can deal with the fall-out :)
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2007-10-22 5:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 1:05 Roel Kluin
2007-10-22 1:42 ` Rik van Riel
2007-10-22 1:53 ` Roel Kluin
2007-10-22 3:08 ` Rik van Riel
2007-10-22 5:02 ` Herbert Xu [this message]
2007-10-22 9:30 ` Pekka Enberg
2007-10-22 15:19 ` Rik van Riel
2007-10-22 15:23 ` Pekka Enberg
2007-10-22 16:42 ` Ray Lee
2007-10-22 17:56 ` Roel Kluin
2007-10-22 18:12 ` Ray Lee
2007-10-22 18:52 ` Roel Kluin
2007-10-22 22:26 ` Rene Herman
2007-10-22 23:00 ` Ray Lee
2007-10-23 0:15 ` Rene Herman
2007-10-22 18:36 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071022050243.GA16384@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=12o3l@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®