From: "Ray Lee" <ray-lk@madrabbit.org>
To: "Roel Kluin" <12o3l@tiscali.nl>
Cc: "Rik van Riel" <riel@redhat.com>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] return hidden bug
Date: Mon, 22 Oct 2007 11:12:23 -0700 [thread overview]
Message-ID: <2c0942db0710221112g7c7d99caj7feb0c2ac5de17e7@mail.gmail.com> (raw)
In-Reply-To: <471CE453.5050208@tiscali.nl>
On 10/22/07, Roel Kluin <12o3l@tiscali.nl> wrote:
> Ray Lee wrote:
>
> > I'm sorry, perhaps I poured myself a cup of stupid this morning, but
> > isn't the above patch effectively introducing a BUG where none could
> > be reached before? In other words, for the patch to have zero
> > behavioral change, wouldn't it have to remove the BUG() altogether?
>
> True, but obviously not intended. I think the intention was to expose this bug.
Arguing intentions is very dangerous. I've written code like that
where the intention is to make it simple to turn a printk into a full
bug and back and forth during development. At the end of the day, the
fact remains that you're changing behavior.
Let me turn this around. Do you have an alpha and have you tried out
your patch? If not, then I'd suggest turning it into a WARN_ON(1)
instead, as in this specific case you're risking turning what was a
working system into one that doesn't.
next prev parent reply other threads:[~2007-10-22 18:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 1:05 Roel Kluin
2007-10-22 1:42 ` Rik van Riel
2007-10-22 1:53 ` Roel Kluin
2007-10-22 3:08 ` Rik van Riel
2007-10-22 5:02 ` Herbert Xu
2007-10-22 9:30 ` Pekka Enberg
2007-10-22 15:19 ` Rik van Riel
2007-10-22 15:23 ` Pekka Enberg
2007-10-22 16:42 ` Ray Lee
2007-10-22 17:56 ` Roel Kluin
2007-10-22 18:12 ` Ray Lee [this message]
2007-10-22 18:52 ` Roel Kluin
2007-10-22 22:26 ` Rene Herman
2007-10-22 23:00 ` Ray Lee
2007-10-23 0:15 ` Rene Herman
2007-10-22 18:36 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c0942db0710221112g7c7d99caj7feb0c2ac5de17e7@mail.gmail.com \
--to=ray-lk@madrabbit.org \
--cc=12o3l@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®