From: Arjan van de Ven <arjan@infradead.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: Jens Axboe <jens.axboe@oracle.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.24-rc1] fix sg_phys to use dma_addr_t
Date: Wed, 24 Oct 2007 19:29:49 -0700 [thread overview]
Message-ID: <20071024192949.346687ed@laptopd505.fenrus.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0710241957240.4733@blonde.wat.veritas.com>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> ---
> Whether this is a complete patch, suitable for all architectures,
> I'm not sure: it builds, boots and runs correctly on the x86_32 box
> in question, but you'll be a lot wiser than me about using dma_addr_t
> for everyone. (Seems a bit of a shame to include <asm/types.h> here,
> when I think all arches already get to include it one way or another,
> typically via asm/scatterlist.h; but I guess it's safest to repeat
> it.)
there is a problem with this... sg_phys doesn't return an actual *dma*
address.... at least not an address you can give to the device.
Using dma_addr_t is thus a bit misleading.....
next prev parent reply other threads:[~2007-10-25 2:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 19:01 Hugh Dickins
2007-10-25 2:29 ` Arjan van de Ven [this message]
2007-10-25 6:40 ` Hugh Dickins
2007-10-25 7:54 ` Jens Axboe
2007-10-25 8:51 ` Rolf Eike Beer
2007-10-25 8:52 ` Jens Axboe
2007-10-25 9:00 ` Rolf Eike Beer
2007-10-25 9:06 ` Jens Axboe
2007-10-25 11:24 ` Rolf Eike Beer
2007-10-25 11:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071024192949.346687ed@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=hugh@veritas.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®