From: Hugh Dickins <hugh@veritas.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2.6.24-rc1] fix sg_phys to use dma_addr_t
Date: Wed, 24 Oct 2007 20:01:16 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0710241957240.4733@blonde.wat.veritas.com> (raw)
x86_32 CONFIG_HIGHMEM64G with 5GB RAM hung when booting, after issuing
some "request_module: runaway loop modprobe binfmt-0000" messages in
trying to exec /sbin/init.
The binprm buf doesn't see the right ".ELF" header because sg_phys()
is providing the wrong physical addresses for high pages: a 32-bit
unsigned long is too small in this case, we need to use dma_addr_t.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
Whether this is a complete patch, suitable for all architectures,
I'm not sure: it builds, boots and runs correctly on the x86_32 box
in question, but you'll be a lot wiser than me about using dma_addr_t
for everyone. (Seems a bit of a shame to include <asm/types.h> here,
when I think all arches already get to include it one way or another,
typically via asm/scatterlist.h; but I guess it's safest to repeat it.)
include/linux/scatterlist.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- 2.6.24-rc1/include/linux/scatterlist.h 2007-10-24 12:42:16.000000000 +0100
+++ linux/include/linux/scatterlist.h 2007-10-24 19:17:13.000000000 +0100
@@ -1,6 +1,7 @@
#ifndef _LINUX_SCATTERLIST_H
#define _LINUX_SCATTERLIST_H
+#include <asm/types.h>
#include <asm/scatterlist.h>
#include <linux/mm.h>
#include <linux/string.h>
@@ -237,7 +238,7 @@ static inline void sg_init_table(struct
* on the sg page.
*
**/
-static inline unsigned long sg_phys(struct scatterlist *sg)
+static inline dma_addr_t sg_phys(struct scatterlist *sg)
{
return page_to_phys(sg_page(sg)) + sg->offset;
}
next reply other threads:[~2007-10-25 1:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 19:01 Hugh Dickins [this message]
2007-10-25 2:29 ` Arjan van de Ven
2007-10-25 6:40 ` Hugh Dickins
2007-10-25 7:54 ` Jens Axboe
2007-10-25 8:51 ` Rolf Eike Beer
2007-10-25 8:52 ` Jens Axboe
2007-10-25 9:00 ` Rolf Eike Beer
2007-10-25 9:06 ` Jens Axboe
2007-10-25 11:24 ` Rolf Eike Beer
2007-10-25 11:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0710241957240.4733@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®