From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>,
Francois Romieu <romieu@fr.zoreil.com>,
Jeff Garzik <jeff@garzik.org>
Cc: Romano Giannetti <romanol@upcomillas.es>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Edward Hsu <edward_hsu@realtek.com.tw>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] r8169: don't call napi_disable if not doing NAPI
Date: Fri, 26 Oct 2007 11:33:05 -0700 [thread overview]
Message-ID: <20071026113305.57dea765@freepuppy.rosehill> (raw)
In-Reply-To: <20071026175613.GA18770@elte.hu>
Don't call napi_disable if not configured.
And make sure that any misuse of napi_xxx in future fails
with a compile error.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
--- a/drivers/net/r8169.c 2007-10-24 21:38:43.000000000 -0700
+++ b/drivers/net/r8169.c 2007-10-26 11:27:02.000000000 -0700
@@ -392,7 +392,9 @@ struct rtl8169_private {
void __iomem *mmio_addr; /* memory map physical address */
struct pci_dev *pci_dev; /* Index of PCI device */
struct net_device *dev;
+#ifdef CONFIG_R8169_NAPI
struct napi_struct napi;
+#endif
spinlock_t lock; /* spin lock flag */
u32 msg_enable;
int chipset;
@@ -2989,13 +2991,16 @@ static void rtl8169_down(struct net_devi
{
struct rtl8169_private *tp = netdev_priv(dev);
void __iomem *ioaddr = tp->mmio_addr;
- unsigned int poll_locked = 0;
unsigned int intrmask;
rtl8169_delete_timer(dev);
netif_stop_queue(dev);
+#ifdef CONFIG_R8169_NAPI
+ napi_disable(&tp->napi);
+#endif
+
core_down:
spin_lock_irq(&tp->lock);
@@ -3009,11 +3014,6 @@ core_down:
synchronize_irq(dev->irq);
- if (!poll_locked) {
- napi_disable(&tp->napi);
- poll_locked++;
- }
-
/* Give a racing hard_start_xmit a few cycles to complete. */
synchronize_sched(); /* FIXME: should this be synchronize_irq()? */
next prev parent reply other threads:[~2007-10-26 18:35 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 4:19 Linux v2.6.24-rc1 Linus Torvalds
2007-10-24 4:49 ` Willy Tarreau
2007-10-24 5:22 ` Dave Young
2007-10-24 7:23 ` Ingo Molnar
2007-10-24 7:32 ` Ohad Ben-Cohen
2007-10-24 7:33 ` Dave Young
2007-10-24 8:12 ` Jens Axboe
2007-10-24 7:44 ` kvm_main.c:220: error: implicit declaration of function 'smp_call_function_mask' Paolo Ornati
2007-10-24 7:56 ` Jeff Garzik
2007-10-24 8:04 ` Linux v2.6.24-rc1 Ingo Molnar
2007-10-24 8:04 ` Christoph Hellwig
2007-10-24 10:17 ` Linux v2.6.24-rc1, x86 arch code quality, unifications Ingo Molnar
2007-10-24 11:07 ` Linux v2.6.24-rc1 Sam Ravnborg
2007-10-24 12:12 ` Ingo Molnar
2007-10-24 12:21 ` Sam Ravnborg
2007-10-24 21:30 ` [RFC - GIT pull] first step to get rid of x86_64 and i386 dirs Sam Ravnborg
2007-10-24 22:50 ` Randy Dunlap
2007-10-25 6:14 ` Yinghai Lu
2007-10-25 10:56 ` Sam Ravnborg
2007-10-25 15:45 ` Randy Dunlap
2007-10-25 10:18 ` Ingo Molnar
2007-10-25 10:55 ` Sam Ravnborg
2007-10-24 8:10 ` [Git Patch] arch/um/drivers/ubd_kern.c: fix a building error WANG Cong
2007-10-24 11:03 ` Jens Axboe
2007-10-24 11:30 ` [git pull] x86 arch updates Ingo Molnar
2007-10-24 11:48 ` Jeff Garzik
2007-10-24 12:03 ` Ingo Molnar
2007-10-24 13:25 ` 2.6.24-rc1 fails with lockup and BUG: Romano Giannetti
2007-10-24 14:27 ` Ingo Molnar
2007-10-24 15:53 ` Romano Giannetti
2007-10-24 15:55 ` Ingo Molnar
2007-10-24 16:11 ` Peter Zijlstra
2007-10-26 5:57 ` Romano Giannetti
2007-10-26 6:37 ` 2.6.24-rc1 fails with lockup - /sbin/ifconfig / inet_ioctl() / dev_close() / rtl8169_down() Ingo Molnar
2007-10-26 16:48 ` Stephen Hemminger
2007-10-26 17:56 ` Ingo Molnar
2007-10-26 18:33 ` Stephen Hemminger [this message]
2007-10-26 20:17 ` [PATCH] r8169: don't call napi_disable if not doing NAPI Francois Romieu
2007-10-28 22:18 ` Romano Giannetti
2007-10-29 8:56 ` Romano Giannetti
2007-10-24 16:44 ` 2.6.24-rc1 fails with lockup and BUG: Joseph Fannin
2007-10-26 5:59 ` Romano Giannetti
2007-10-24 18:19 ` Linux v2.6.24-rc1 Giacomo Catenazzi
2007-12-04 10:08 ` [Bug 9246] On 2.6.24-rc1-gc9927c2b BUG: unable to handle kernel paging request at virtual address 3d15b925 Ingo Molnar
2007-12-04 16:47 ` Giacomo A. Catenazzi
2007-12-04 20:08 ` Rafael J. Wysocki
2007-12-05 9:26 ` Giacomo A. Catenazzi
2007-10-24 19:44 ` [patch] portman2x4.c: fix boot hang Ingo Molnar
2007-10-24 20:12 ` Frans Pop
2007-10-24 21:29 ` Ingo Molnar
2007-10-25 8:16 ` Takashi Iwai
2007-10-25 5:18 ` 2.6.24-rc1 doesn't build Theodore Tso
2007-10-25 5:30 ` Kamalesh Babulal
2007-10-25 12:45 ` Linux v2.6.24-rc1 edz_mania
2007-10-26 5:19 ` [PATCH] Dump filtering supports x86_64 sparsemem(Re: Linux v2.6.24-rc1) Ken'ichi Ohmichi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071026113305.57dea765@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edward_hsu@realtek.com.tw \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=romanol@upcomillas.es \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®