Re: Linux v2.6.24-rc1

["Dave Young" <hidave.darkstar@gmail.com>]

On 10/24/07, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Dave Young <hidave.darkstar@gmail.com> wrote:
>
> > Hi,
> > build failed on my pc:
> >
> > arch/x86/kernel/built-in.o(.text+0x1b192): In function
> > `smp_send_nmi_allbutself':
> > : undefined reference to `genapic'
>
> please send us the .config you are using. Chances are that the patch
> below will fix the build breakage for you.
>
Hi,
Yes, I have tried it, works fine.

Part of my .config:
#
# Automatically generated make config: don't edit
# Linux kernel version: 2.6.24-rc1
# Wed Oct 24 13:02:24 2007
#
CONFIG_X86_32=y
CONFIG_GENERIC_TIME=y
CONFIG_GENERIC_CMOS_UPDATE=y
CONFIG_CLOCKSOURCE_WATCHDOG=y
CONFIG_GENERIC_CLOCKEVENTS=y
CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_SEMAPHORE_SLEEPERS=y
CONFIG_X86=y
CONFIG_MMU=y
CONFIG_ZONE_DMA=y
CONFIG_QUICKLIST=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_IOMAP=y
CONFIG_GENERIC_BUG=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
CONFIG_DMI=y
CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config"
----cut----
>         Ingo
>
> --------------------->
> Subject: x86: fix CONFIG_KEXEC build breakage
> From: Mike Galbraith <efault@gmx.de>
>
> X86_32 build fix to commit 62a31a03b3d2a9d20e7a073e2cd9b27bfb7d6a3f
>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  arch/x86/kernel/crash.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> Index: linux/arch/x86/kernel/crash.c
> ===================================================================
> --- linux.orig/arch/x86/kernel/crash.c
> +++ linux/arch/x86/kernel/crash.c
> @@ -25,7 +25,7 @@
>  #include <linux/kdebug.h>
>  #include <asm/smp.h>
>
> -#ifdef X86_32
> +#ifdef CONFIG_X86_32
>  #include <mach_ipi.h>
>  #else
>  #include <asm/mach_apic.h>
> @@ -41,7 +41,7 @@ static int crash_nmi_callback(struct not
>                         unsigned long val, void *data)
>  {
>         struct pt_regs *regs;
> -#ifdef X86_32
> +#ifdef CONFIG_X86_32
>         struct pt_regs fixed_regs;
>  #endif
>         int cpu;
> @@ -60,7 +60,7 @@ static int crash_nmi_callback(struct not
>                 return NOTIFY_STOP;
>         local_irq_disable();
>
> -#ifdef X86_32
> +#ifdef CONFIG_X86_32
>         if (!user_mode_vm(regs)) {
>                 crash_fixup_ss_esp(&fixed_regs, regs);
>                 regs = &fixed_regs;
>