* [PATCH] Fix a spurious kfree_skb() call
@ 2007-10-30 23:10 Michal Januszewski
2007-10-31 3:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Michal Januszewski @ 2007-10-30 23:10 UTC (permalink / raw)
To: linux-kernel; +Cc: den, davem, dex, johnpol
Remove a spurious call to kfree_skb() in the connector rx_skb handler.
This fixes a regression introduced by the '[NET]: make netlink user ->
kernel interface synchronious' patch (cd40b7d3983c708aabe3d3008ec64ffce56d33b0)
Signed-off-by: Michal Januszewski <spock@gentoo.org>
---
diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c
index 0e328d3..6883fcb 100644
--- a/drivers/connector/connector.c
+++ b/drivers/connector/connector.c
@@ -218,7 +218,7 @@ static void cn_rx_skb(struct sk_buff *__skb)
skb->len < nlh->nlmsg_len ||
nlh->nlmsg_len > CONNECTOR_MAX_MSG_SIZE) {
kfree_skb(skb);
- goto out;
+ return;
}
len = NLMSG_ALIGN(nlh->nlmsg_len);
@@ -229,9 +229,6 @@ static void cn_rx_skb(struct sk_buff *__skb)
if (err < 0)
kfree_skb(skb);
}
-
-out:
- kfree_skb(__skb);
}
/*
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Fix a spurious kfree_skb() call
2007-10-30 23:10 [PATCH] Fix a spurious kfree_skb() call Michal Januszewski
@ 2007-10-31 3:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-10-31 3:42 UTC (permalink / raw)
To: spock; +Cc: linux-kernel, den, dex, johnpol
From: Michal Januszewski <spock@gentoo.org>
Date: Wed, 31 Oct 2007 00:10:52 +0100
> Remove a spurious call to kfree_skb() in the connector rx_skb handler.
>
> This fixes a regression introduced by the '[NET]: make netlink user ->
> kernel interface synchronious' patch (cd40b7d3983c708aabe3d3008ec64ffce56d33b0)
>
> Signed-off-by: Michal Januszewski <spock@gentoo.org>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-31 3:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-30 23:10 [PATCH] Fix a spurious kfree_skb() call Michal Januszewski
2007-10-31 3:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®