From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: pm list <linux-pm@lists.linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [linux-pm] [RFC][PATCH 1/3] Suspend: Testing facility
Date: Fri, 2 Nov 2007 12:04:10 +0100 [thread overview]
Message-ID: <200711021204.11093.rjw@sisk.pl> (raw)
In-Reply-To: <1193999626.25744.5.camel@johannes.berg>
On Friday, 2 November 2007 11:33, Johannes Berg wrote:
>
> > 5 - test the freezing of processes
>
> > +/* Suspend test levels */
> > +enum {
> > + TEST_NONE,
>
> Without reading the code, I assume that this enum controls those levels.
> I think a comment that it is user-space visible API and should not be
> reordered would be warranted.
Yes, you are right. I'll add the comment.
Thanks,
Rafael
next prev parent reply other threads:[~2007-11-02 10:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-01 22:57 [RFC][PATCH 0/3] Suspend and hibernation test facility Rafael J. Wysocki
2007-11-01 22:58 ` [RFC][PATCH 1/3] Suspend: Testing facility Rafael J. Wysocki
2007-11-02 10:33 ` [linux-pm] " Johannes Berg
2007-11-02 11:04 ` Rafael J. Wysocki [this message]
2007-11-03 18:23 ` Pavel Machek
2007-11-03 18:54 ` Rafael J. Wysocki
2007-11-01 22:59 ` [RFC][PATCH 2/3] Hibernation: New testing facility Rafael J. Wysocki
2007-11-01 23:00 ` [RFC][PATCH 3/3] PM: Suspend/hibernation debug documentation update Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711021204.11093.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®