From: David Miller <davem@davemloft.net>
To: torvalds@linux-foundation.org
Cc: gregkh@suse.de, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
pcihpd-discuss@lists.sourceforge.net
Subject: Re: [GIT PATCH] PCI patches for 2.6.24-rc1
Date: Mon, 05 Nov 2007 15:24:51 -0800 (PST) [thread overview]
Message-ID: <20071105.152451.260321864.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.0.999.0711051432531.15101@woody.linux-foundation.org>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mon, 5 Nov 2007 14:37:31 -0800 (PST)
> So let me one more say:
>
> - don't just say
>
> .. was cured by commit xyz
>
> - but add the one-liner description of the commit, something along the
> lines of
>
> .. was cured by commit xyz ("PCI: Add quirk for devices which
> disable MSI when INTX_DISABLE is set.")
>
> so that the commit messages are readable even outside git.
I agree, and I've been trying to get into the habit of
doing this even though I didn't this time.
next prev parent reply other threads:[~2007-11-05 23:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 21:56 Greg KH
2007-11-05 22:13 ` Linus Torvalds
2007-11-05 22:16 ` Linus Torvalds
2007-11-05 22:28 ` Greg KH
2007-11-05 22:42 ` Linus Torvalds
2007-11-05 23:28 ` David Miller
2007-11-06 16:14 ` Theodore Tso
2007-11-06 16:47 ` Linus Torvalds
2007-11-05 22:17 ` Greg KH
2007-11-05 22:37 ` Linus Torvalds
2007-11-05 23:24 ` David Miller [this message]
2007-11-05 23:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071105.152451.260321864.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=pcihpd-discuss@lists.sourceforge.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®