From: Linus Torvalds <torvalds@linux-foundation.org>
To: Greg KH <gregkh@suse.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
pcihpd-discuss@lists.sourceforge.net
Subject: Re: [GIT PATCH] PCI patches for 2.6.24-rc1
Date: Mon, 5 Nov 2007 14:37:31 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.0.999.0711051432531.15101@woody.linux-foundation.org> (raw)
In-Reply-To: <20071105221752.GA9509@suse.de>
On Mon, 5 Nov 2007, Greg KH wrote:
> >
> > This one is bogus:
> >
> > PCI: Revert "PCI: disable MSI by default on systems with Serverworks HT1000 chips"
> >
> > This reverts commit e3008dedff4bdc96a5f67224cd3d8d12237082a0.
> >
> > The real bug was an INTX issue in the tg3 ethernet chip, and
> > cured by commit c129d962a66c76964954a98b38586ada82cf9381
> >
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> > Acked-by: Jeff Garzik <jgarzik@redhat.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> I'll defer to David on this one, as he sent it to me.
Btw, I'd also like to take the opportunitity to ask people to always
include the explanation of the commit when you give a commit ID.
"git revert" does that for the commit it reverts, but the (bogus) commit
ID that was apparently added by David (c129d962a) didn't get the
explanation for it, so now it's totally impossible to match it up with
anything at all..
So let me one more say:
- don't just say
.. was cured by commit xyz
- but add the one-liner description of the commit, something along the
lines of
.. was cured by commit xyz ("PCI: Add quirk for devices which
disable MSI when INTX_DISABLE is set.")
so that the commit messages are readable even outside git.
Linus
next prev parent reply other threads:[~2007-11-05 22:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 21:56 Greg KH
2007-11-05 22:13 ` Linus Torvalds
2007-11-05 22:16 ` Linus Torvalds
2007-11-05 22:28 ` Greg KH
2007-11-05 22:42 ` Linus Torvalds
2007-11-05 23:28 ` David Miller
2007-11-06 16:14 ` Theodore Tso
2007-11-06 16:47 ` Linus Torvalds
2007-11-05 22:17 ` Greg KH
2007-11-05 22:37 ` Linus Torvalds [this message]
2007-11-05 23:24 ` David Miller
2007-11-05 23:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0711051432531.15101@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=pcihpd-discuss@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®