From: Oliver Neukum <oliver@neukum.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: gregkh@suse.de, linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] usb/serial/oti6858.c: cleanups
Date: Mon, 5 Nov 2007 21:40:43 +0100 [thread overview]
Message-ID: <200711052140.44505.oliver@neukum.org> (raw)
In-Reply-To: <20071105170757.GY12045@stusta.de>
Am Montag 05 November 2007 schrieb Adrian Bunk:
> This patch containsthe following cleanups:
> - make the needlessly global send_data() static
> - an author without anemail address is OK, not a FIXME
That should be up to the author. If he thinks it should be there it might
be worth a FIXME
> - directly put the IDs into the id_table
Why?
> - remove the now-empty oti6858.h
> - kill the pointless driver version number
Why? There might be a new version in the future. If the author put
it there he might have had his reasons.
Regards
Oliver
next prev parent reply other threads:[~2007-11-05 20:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 17:07 Adrian Bunk
2007-11-05 20:40 ` Oliver Neukum [this message]
2007-11-12 10:37 ` Adrian Bunk
2007-11-12 13:14 ` [linux-usb-devel] " Oliver Neukum
2007-11-12 13:31 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711052140.44505.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=bunk@kernel.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome