* [PATCH 1/2] UML - Fix recvmsg return value checking
@ 2007-11-12 15:45 Jeff Dike
0 siblings, 0 replies; only message in thread
From: Jeff Dike @ 2007-11-12 15:45 UTC (permalink / raw)
To: Andrew Morton; +Cc: LKML, uml-devel
Stupid bug - we need to compare the return value of recvmsg to the
value of iov_len, not its size. This caused port_helper processes not
to be killed on shutdown on x86_64 because the pids weren't being
passed out properly.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
---
arch/um/os-Linux/file.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Index: linux-2.6/arch/um/os-Linux/file.c
===================================================================
--- linux-2.6.orig/arch/um/os-Linux/file.c 2007-11-12 10:26:26.000000000 -0500
+++ linux-2.6/arch/um/os-Linux/file.c 2007-11-12 10:32:30.000000000 -0500
@@ -496,8 +496,7 @@ int os_rcv_fd(int fd, int *helper_pid_ou
n = recvmsg(fd, &msg, 0);
if(n < 0)
return -errno;
-
- else if(n != sizeof(iov.iov_len))
+ else if(n != iov.iov_len)
*helper_pid_out = -1;
cmsg = CMSG_FIRSTHDR(&msg);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-11-12 15:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-12 15:45 [PATCH 1/2] UML - Fix recvmsg return value checking Jeff Dike
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®