mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: russ@elegant-software.com, linux-kernel@vger.kernel.org
Subject: Re: OT: Does Linux have any "Perfect Code"
Date: Wed, 14 Nov 2007 23:11:47 -0800 (PST)	[thread overview]
Message-ID: <20071114.231147.223986050.davem@davemloft.net> (raw)
In-Reply-To: <473BE75B.9070701@cosmosbay.com>

From: Eric Dumazet <dada1@cosmosbay.com>
Date: Thu, 15 Nov 2007 07:29:47 +0100

> hrtime_t
> ts2hrt(const timestruc_t *tsp)
> {
> return tsp->tv_sec * NANOSEC + tsp->tv_nsec;
> }
> 
> can be inlined as it is trivial (and much faster than Solaris version)
> 
>          movq    (%rdi), %rdx
>          mov     8(%rdi), %eax
>          imulq   $1000000000, %rdx, %rdx
>          addq    %rdx, %rax

This is exactly the kind of thing that is not happening to the Solaris
code base.  These gradual improvements that are being done constantly
to every nook and cranny of the Linux kernel.

Code sits untouched for 6+ years in the Solaris tree not because it's
perfect and bug free, but rather because Sun simply does not have the
environment and resources with which to make the kinds of ongoing
improvements Linux can.

The things Sun is trying to say is so great about the Solaris code
base is actually, as shown by Eric, it's greatest weakness.
Development is glacial and a lot of stuff simply does not get looked
at.

Someone who really wants to get some kind of idea on what scale Linux
development is compared to Solaris should sit down with a current
Linux git tree and a current OpenSolaris mercurial checkout and do
some comparisons.

Here is one you could ferret out that I am pretty sure of.  I bet that
in the 2.6.24 merge window (1.5 weeks of merging patches) we had more
individual contributors to the Linux kernel than OpenSolaris has had
in it's entire existence.

  reply	other threads:[~2007-11-15  7:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-15  1:21 Russell Leighton
2007-11-15  1:33 ` David Miller
2007-11-15  6:29 ` Eric Dumazet
2007-11-15  7:11   ` David Miller [this message]
2007-11-15  7:43   ` Andi Kleen
2007-11-15  8:27 ` Philippe Elie
2007-11-15 13:16   ` Michael Gerdau
2007-11-15 15:10     ` Daniel Barkalow
2007-11-17  8:44       ` Geert Uytterhoeven
2007-11-15 17:05     ` Chris Friesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071114.231147.223986050.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dada1@cosmosbay.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=russ@elegant-software.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®