mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Daniel Walker <dwalker@mvista.com>
Cc: Remy Bohmer <linux@bohmer.net>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	RT <linux-rt-users@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [BUG on PREEMPT_RT, 2.6.23.1-rt5] in rt-mutex code and signals
Date: Sat, 17 Nov 2007 19:04:30 +0100	[thread overview]
Message-ID: <20071117180430.GA10768@elte.hu> (raw)
In-Reply-To: <1195322141.25393.41.camel@imap.mvista.com>


* Daniel Walker <dwalker@mvista.com> wrote:

> On Sat, 2007-11-17 at 18:46 +0100, Ingo Molnar wrote:
> > * Daniel Walker <dwalker@mvista.com> wrote:
> > 
> > > > Actually, IMO, compat_semaphores behave like semaphores should 
> > > > behave, and thus the same as they behave on a non-RT kernel, and at 
> > > > the locations where the semaphores are now misused as mutexes on RT, 
> > > > we should replace them by differently-named-mutex-type-semaphores, 
> > > > or better: real-RT-mutexes..
> > > 
> > > The vast majority of semaphore are actually binary semaphores in the 
> > > Linux kernel .. So it's easier to mass convert semaphores to mutexes, 
> > > then address the ones that don't conform.. Usually they are converted 
> > > to the complete API in mainline..
> > 
> > right now there are 3992 mutex_lock() critical sections in the kernel 
> > and only 351 down() based critical sections are left.
> > 
> > fixing the top 20:
> > 
> >       4 &vuart_bus_priv.probe_mutex
> >       5 &connections_lock
> >       5 &irq_ptr->setting_up_sema
> >       5 &kbd->sem
> >       5 &pnp_res_mutex
> >       5 &port->port_lock
> >       5 &tq_init_sem
> >       6 &adb_handler_sem
> >       6 &dev->parent->sem
> >       6 &driver_lock
> >       6 &ha->vport_sem
> >       7 &big_buffer_sem
> >       8 &dir_f->sem
> >       9 &c->alloc_sem
> >      11 &dev->sem
> >      11 &usbvision->lock
> >      12 &c->erase_free_sem
> >      15 &u132->scheduler_lock
> >      16 &zfcp_data.config_sema
> >      17 &f->sem
> > 
> > would remove 164 of them, so it would convert half of the remaining 
> > semaphore use in the kernel. So the job is almost finished - would 
> > anyone like to go for the final grand feat: complete removal of 
> > semaphores from the kernel? :-)
> 
> Sure, you want to split the list?

split the list with you? Feel free to take any of those :-) dev->sem is 
nontrivial and probably not possible right now - and some of the others 
might be problematic too. But there might be fixable ones in the list. 
This shouldnt become like the BKL conversion - never truly finished.

	Ingo

  reply	other threads:[~2007-11-17 18:05 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-16 15:51 Remy Bohmer
2007-11-16 20:20 ` Steven Rostedt
2007-11-16 23:02   ` Remy Bohmer
2007-11-16 23:37     ` Steven Rostedt
2007-11-17 11:44       ` Remy Bohmer
2007-11-17 14:08         ` Steven Rostedt
2007-11-17 15:06           ` Steven Rostedt
2007-11-17 15:36           ` Remy Bohmer
2007-11-19 12:55             ` Remy Bohmer
2007-11-19 13:54               ` Steven Rostedt
2007-11-17 16:22         ` Daniel Walker
2007-11-17 17:09           ` Remy Bohmer
2007-11-17 17:29             ` Daniel Walker
2007-11-17 17:46               ` Ingo Molnar
2007-11-17 17:55                 ` Daniel Walker
2007-11-17 18:04                   ` Ingo Molnar [this message]
2007-11-17 18:12                     ` Daniel Walker
2007-11-18 12:33                       ` Peter Zijlstra
2007-11-18 22:26                         ` David Chinner
2007-11-17 22:49                     ` Remy Bohmer
2007-11-19  7:25                   ` Jon Masters
2007-11-19 15:31                     ` Daniel Walker
2007-11-19 15:51                       ` Remy Bohmer
2007-11-19 16:11                         ` Daniel Walker
2007-11-20 16:43                 ` Daniel Walker
2007-11-20 20:37                   ` Ingo Molnar
2007-11-20 20:54                     ` Daniel Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071117180430.GA10768@elte.hu \
    --to=mingo@elte.hu \
    --cc=dwalker@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=linux@bohmer.net \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®