mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Remy Bohmer" <linux@bohmer.net>
To: "Steven Rostedt" <rostedt@goodmis.org>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	RT <linux-rt-users@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Daniel Walker" <dwalker@mvista.com>
Subject: Re: [BUG on PREEMPT_RT, 2.6.23.1-rt5] in rt-mutex code and signals
Date: Mon, 19 Nov 2007 13:55:45 +0100	[thread overview]
Message-ID: <3efb10970711190455n5e635823t40a320c4b444fa57@mail.gmail.com> (raw)
In-Reply-To: <3efb10970711170736u469bbbc5p8c227ca2a12657dd@mail.gmail.com>

Hello Steven,

> > OK, I wont be able to work on this this weekend, but I'll try to get to it
> > on Monday.  A better example to show the bug you are looking for is simply
> > create a mutex and create a thread that grabs that mutex and goes to
> > sleep. Have your driver read grab that mutex with
> > mutex_lock_interruptible. And if the signal code is broken with this, then
> > you definitely got a point that the inerruptible code is broken.

I removed the 'struct semaphore' completely from my driver, using real
mutexes now instead, replace the signalling semaphores by 'struct
completion' mechanisms and got rid of the possible race I saw with the
completions in a different way, and now the problem is completely
gone!

Posix Signals work properly now (no OOPS anymore), so the problem was
likely related to the way I used the 'struct semaphore' types, which
is thus different compared to the non-RT kernel and therefor quite
confusing.

So, thank you (and Daniel) for pointing me into the right direction.

Now lets get rid of the 'struct semaphore' completely in the kernel :-))


Kind Regards,

Remy Bohmer

  reply	other threads:[~2007-11-19 12:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-16 15:51 Remy Bohmer
2007-11-16 20:20 ` Steven Rostedt
2007-11-16 23:02   ` Remy Bohmer
2007-11-16 23:37     ` Steven Rostedt
2007-11-17 11:44       ` Remy Bohmer
2007-11-17 14:08         ` Steven Rostedt
2007-11-17 15:06           ` Steven Rostedt
2007-11-17 15:36           ` Remy Bohmer
2007-11-19 12:55             ` Remy Bohmer [this message]
2007-11-19 13:54               ` Steven Rostedt
2007-11-17 16:22         ` Daniel Walker
2007-11-17 17:09           ` Remy Bohmer
2007-11-17 17:29             ` Daniel Walker
2007-11-17 17:46               ` Ingo Molnar
2007-11-17 17:55                 ` Daniel Walker
2007-11-17 18:04                   ` Ingo Molnar
2007-11-17 18:12                     ` Daniel Walker
2007-11-18 12:33                       ` Peter Zijlstra
2007-11-18 22:26                         ` David Chinner
2007-11-17 22:49                     ` Remy Bohmer
2007-11-19  7:25                   ` Jon Masters
2007-11-19 15:31                     ` Daniel Walker
2007-11-19 15:51                       ` Remy Bohmer
2007-11-19 16:11                         ` Daniel Walker
2007-11-20 16:43                 ` Daniel Walker
2007-11-20 20:37                   ` Ingo Molnar
2007-11-20 20:54                     ` Daniel Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3efb10970711190455n5e635823t40a320c4b444fa57@mail.gmail.com \
    --to=linux@bohmer.net \
    --cc=dwalker@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®